Page MenuHomePhorge
Differential D4457

Lookup existing events even when creating a new event
ClosedPublic
Actions

Authored by mollekopf on Jul 26 2023, 12:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 8, 8:01 PM
Unknown Object (File)
Tue, Jan 7, 10:51 AM
Unknown Object (File)
Sat, Jan 4, 1:45 PM
Unknown Object (File)
Sat, Jan 4, 1:45 PM
Unknown Object (File)
Sat, Jan 4, 1:45 PM
Unknown Object (File)
Sat, Jan 4, 1:45 PM
Unknown Object (File)
Sat, Jan 4, 1:45 PM
Unknown Object (File)
Sat, Jan 4, 1:45 PM
View All Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Syncroton Developers
Commits
rS7c885b475414: Lookup existing events even when creating a new event
rS94f67be1d5a9: Lookup existing events even when creating a new event
Summary

If the client doesn't know about an already existing event, we will
otherwise overwrite whatever was there (because the uid and therefor
serverid will be the same). In case of outlooks dummy event
on acceptance that means resetting the attendee status to 0 (after it
was set to accepted via the MeetingResponse).

Diff Detail

Repository
rS syncroton
Branch
dev/mollekopf
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 43703
Build 17492: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Jul 26 2023, 12:00 PM
mollekopf created this revision.
Harbormaster completed remote builds in B43682: Diff 12734.Jul 26 2023, 12:00 PM
mollekopf added a reviewer: Syncroton Developers.Jul 26 2023, 12:04 PM

I suppose we'll need the same thing for all non mail types.

mollekopf updated this revision to Diff 12752.Jul 26 2023, 1:40 PM
mollekopf retitled this revision from Lookup existing events even when creating a new event to Lookup existing events/todos/... even when creating a new entry.
mollekopf edited the summary of this revision. (Show Details)

Generalized the lookup to apply to all types

Harbormaster completed remote builds in B43700: Diff 12752.Jul 26 2023, 1:40 PM
mollekopf added a comment.Jul 26 2023, 1:51 PM

That last change was not useful, it's actually event specific. No other type has a uid in activesync (not even tasks), so I don't suppose there is a method to deduplicate anything.

mollekopf updated this revision to Diff 12755.Jul 26 2023, 1:53 PM
mollekopf retitled this revision from Lookup existing events/todos/... even when creating a new entry to Lookup existing events even when creating a new event.
mollekopf edited the summary of this revision. (Show Details)

Revert to be event specific

Harbormaster completed remote builds in B43703: Diff 12755.Jul 26 2023, 1:53 PM
machniak requested changes to this revision.Jul 26 2023, 3:04 PM
machniak subscribed.
machniak added inline comments.
lib/kolab_sync_data_calendar.php
359

After you removed $event this line needs to change.

This revision now requires changes to proceed.Jul 26 2023, 3:04 PM
mollekopf updated this revision to Diff 12773.Jul 26 2023, 4:03 PM

Check the $entry instead of the $event

Harbormaster completed remote builds in B43721: Diff 12773.Jul 26 2023, 4:03 PM
machniak accepted this revision.Jul 26 2023, 7:21 PM
This revision is now accepted and ready to land.Jul 26 2023, 7:21 PM
Closed by commit rS7c885b475414: Lookup existing events even when creating a new event (authored by mollekopf). · Explain WhyJul 27 2023, 12:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
17 lines

Diff 12755

View Options

lib/kolab_sync_data_calendar.php

Loading...