Page MenuHomePhorge

Initial support for meeting request
ClosedPublic

Authored by mollekopf on Jul 21 2023, 5:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 24, 4:35 PM
Unknown Object (File)
Wed, May 22, 3:52 AM
Unknown Object (File)
Wed, May 22, 1:03 AM
Unknown Object (File)
Tue, May 21, 9:13 AM
Unknown Object (File)
Mon, May 20, 4:24 PM
Unknown Object (File)
Sun, May 19, 9:55 PM
Unknown Object (File)
Sun, May 19, 10:58 AM
Unknown Object (File)
Sat, May 18, 2:54 AM
Subscribers

Diff Detail

Repository
rS syncroton
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
machniak subscribed.
machniak added inline comments.
lib/kolab_sync_data_email.php
392

This line is redundant.

396–435

Redundant.

399

I suppose we could remove these if conditions.

407

Yeah. Fill in the details.

425

I suppose we should use kolab_sync_data_calendar::getEntry() or just de-duplicate/use some code from there.

This revision now requires changes to proceed.Jul 24 2023, 3:02 PM
machniak added inline comments.
lib/kolab_sync_data_email.php
408

The fact an event has exceptions does not mean this specific invitation is an exception. If the invitation includes exceptions I'd say it's definitely not an exception.

410

MeetingRequest has a different structure than Event. E.g. it has Recurrences property, but the later has recurrence. Look at 4th argument of recurrence_from_kolab(), but it's not that simple, I'm afraid.

459

The property might be unset, then itt defaults to MESSAGE_TYPE_NORMAL.

This revision now requires changes to proceed.Jul 27 2023, 8:55 AM
mollekopf added inline comments.
lib/kolab_sync_data_email.php
399

I don't think we should for performance reasons.

408

Right, I confused it with how we store exceptions separately in storage, but that is more a recurrenceId thing and doesn't apply to invitations (I think?).

410

I'm just not going to implement recurrences until we see a need to, so I'll comment/remove this entire section.

459

That's the idea (per spec 0 is the default).

mollekopf marked an inline comment as done.

Removed recurrences/php8 compat

lib/kolab_sync_data_email.php
399

I think get_invitation_event_from_message() is smart enough to not have a performance penalty when there's no invitation. My point is that it has a more sophisticated way to determine the invitation part. So, we'd have parity between syncroton and webclient in this regard.

445

My point was that the else could be removed. I also wonder what we should do when method=CANCEL (or REPLY).

lib/kolab_sync_data_email.php
399

I think you might be right.

Removed the extra header checks

This revision is now accepted and ready to land.Jul 27 2023, 12:04 PM
This revision was automatically updated to reflect the committed changes.