Page MenuHomePhorge

Fix From/Reply-To headers (T622657)
ClosedPublic

Authored by machniak on Jun 19 2023, 12:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 4:07 AM
Unknown Object (File)
Fri, Apr 12, 11:52 AM
Unknown Object (File)
Tue, Apr 9, 10:07 AM
Unknown Object (File)
Mon, Apr 8, 4:02 AM
Unknown Object (File)
Thu, Apr 4, 3:39 AM
Unknown Object (File)
Wed, Apr 3, 1:20 PM
Unknown Object (File)
Wed, Apr 3, 1:20 PM
Unknown Object (File)
Wed, Apr 3, 1:20 PM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK320203e36a0a: Fix From/Reply-To headers (T622657)
Summary
  • Fixes duplicate/wrong Reply-To and From header
  • Don't use Laravel global settings, they don't play well with our tenants.
  • We anyway can't check for Laravel global headers in our tests
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
mollekopf added inline comments.
src/config/mail.php
95–101

Can we explicitly set 'from' and 'reply_to' to null to be a bit more explicit (besides the comment)?

This revision now requires changes to proceed.Jul 17 2023, 10:06 AM
  • Merge branch 'master' into dev/replyto-fix
  • Be more specific in the config file
This revision is now accepted and ready to land.Jul 24 2023, 2:33 PM
This revision was automatically updated to reflect the committed changes.