Issues a jwt token signed by app.vpn.signing_key
Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rKf127175fc56e: VPNController
rK8f494e782cb2: VPNController
rKd7cae8cfcf2e: VPNController
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/mollekopf
- Lint
Lint Errors Severity Location Code Message Error src/app/Http/Controllers/API/V4/VPNController.php:28 phpstan Method App\Http\Controllers\API\V4\VPNController::token() should return Illuminate\Http\Response but returns Illuminate\Http\JsonResponse. Error src/tests/Feature/Controller/VPNTest.php:53 phpstan Method Lcobucci\JWT\Token\Parser::parse() invoked with 2 parameters, 1 required. Error src/tests/Feature/Controller/VPNTest.php:58 phpstan Call to an undefined method Lcobucci\JWT\Token::claims(). Error src/tests/Feature/Controller/VPNTest.php:59 phpstan Call to an undefined method Lcobucci\JWT\Token::claims(). Error src/tests/Feature/Controller/VPNTest.php:62 phpstan Call to an undefined method Lcobucci\JWT\Token::claims(). - Unit
No Test Coverage - Build Status
Buildable 42959 Build 17264: arc lint + arc unit
Event Timeline
| src/tests/Feature/Controller/VPNTest.php | ||
|---|---|---|
| 54 | I have this usage from https://lcobucci-jwt.readthedocs.io/en/latest/quick-start/ ((under "Parsing tokens"), not sure what's up with the linting, but I'll have to test the signature verification indeed. | |
| src/app/Http/Controllers/API/V4/VPNController.php | ||
|---|---|---|
| 27 | This check is redundant. The route requires authentication. I'd remove this. It will fix the linting issue. | |
| 31 | I'd like to see the option described in config/app.php. Also, should we throw an exception when it's not set? | |
| 41 | Do we really not want to return JSON to be consistent with the whole API? | |
| src/tests/Feature/Controller/VPNTest.php | ||
| 101 | These linting errors are probably JWT issues, but we should silence them. Maybe telling phpstan what exactly $token is (Lcobucci\JWT\UnencryptedToken?) would fix it. | |