Page MenuHomePhorge
Differential D4334

Fix award/penalty rounding issue
ClosedPublic
Actions

Authored by machniak on May 22 2023, 9:11 AM.
Tags
None
Referenced Files
F11968332: D4334.diff
Thu, May 2, 1:42 AM
Unknown Object (File)
Tue, Apr 30, 2:59 AM
Unknown Object (File)
Mon, Apr 29, 10:38 AM
Unknown Object (File)
Wed, Apr 17, 10:37 AM
Unknown Object (File)
Wed, Apr 17, 10:37 AM
Unknown Object (File)
Wed, Apr 17, 10:37 AM
Unknown Object (File)
Mon, Apr 15, 4:04 AM
Unknown Object (File)
Sun, Apr 14, 3:02 AM
View All 76 Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKafb87eeab85a: Fix award/penalty rounding issue
Summary

Also unify the "money to cents convertion" code in other places.

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/rounding-fix
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 42875
Build 17243: arc lint + arc unit

Event Timeline

machniak requested review of this revision.May 22 2023, 9:11 AM
machniak created this revision.
Harbormaster completed remote builds in B42875: Diff 12407.May 22 2023, 9:11 AM
vanmeeuwen accepted this revision.May 22 2023, 10:37 AM
This revision is now accepted and ready to land.May 22 2023, 10:37 AM
Closed by commit rKafb87eeab85a: Fix award/penalty rounding issue (authored by machniak). · Explain WhyMay 23 2023, 8:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
Admin/
2 lines
14 lines
Providers/
Payment/
2 lines
tests/
Feature/
Controller/
Admin/
12 lines

Diff 12407

View Options

src/app/Http/Controllers/API/V4/Admin/WalletsController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/PaymentsController.php

Loading...
View Options

src/app/Providers/Payment/Stripe.php

Loading...
View Options

src/tests/Feature/Controller/Admin/WalletsTest.php

Loading...