Paths

Table of Contentst

Differential D4304

Merge user info and profile pages
ClosedPublic
Actions

Authored by machniak on May 17 2023, 1:35 PM.

Tags

None

Referenced Files

	F12010881: D4304.diff
	Sun, May 5, 12:47 AM

	Unknown Object (File)
	Sat, Apr 27, 12:57 AM

	Unknown Object (File)
	Wed, Apr 17, 10:35 AM

	Unknown Object (File)
	Wed, Apr 17, 10:35 AM

	Unknown Object (File)
	Wed, Apr 17, 10:35 AM

	Unknown Object (File)
	Wed, Apr 17, 10:35 AM

	Unknown Object (File)
	Mon, Apr 15, 4:01 AM

	Unknown Object (File)
	Sat, Apr 13, 8:40 PM

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rKece7ec0245aa: Merge user info and profile pages

Summary

Renamed Settings (/settings) to Policies (/policies)
Renamed Your profile (/profile) to My account (/settings)
/profile/delete page replaced with a dialog
merged user form content with profile page content, i.e. added Personal information tab
Restructured also the My account page, so it is the same as user info page (depending whether you're an account controller or not)

Test Plan

./phpunit --testsuite=Browser

Diff Detail

Repository

Branch

dev/profile-settings-merge

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 42830
Build 17207: arc lint + arc unit

Event Timeline

machniak requested review of this revision.May 17 2023, 1:35 PM

machniak created this revision.

Harbormaster completed remote builds in B42830: Diff 12365.May 17 2023, 1:35 PM

machniak edited the summary of this revision. (Show Details)May 17 2023, 1:36 PM

Fix (and test) changing password via My account

Harbormaster completed remote builds in B42833: Diff 12371.May 17 2023, 2:10 PM

machniak mentioned this in D4310: Add option to disable access to subscriptions (APP_WITH_SUBSCRIPTIONS).May 18 2023, 3:00 PM

mollekopf accepted this revision.May 22 2023, 3:55 PM

This revision is now accepted and ready to land.May 22 2023, 3:55 PM

Closed by commit rKece7ec0245aa: Merge user info and profile pages (authored by machniak). · Explain WhyMay 23 2023, 8:49 AM

This revision was automatically updated to reflect the committed changes.

machniak mentioned this in rKbdc940479f27: Add option to disable access to subscriptions (APP_WITH_SUBSCRIPTIONS).

Revision Contents
Changeset List

Path

Size

src/

app/

Backends/

2 lines

2 lines

resources/

js/

user/

26 lines

lang/

en/

18 lines

fr/

1 line

themes/

3 lines

vue/

9 lines

	Policies.vue
	Settings.vue

12 lines

User/

191 lines

ProfileDelete.vue

tests/

Browser/

3 lines

20 lines

Pages/

	Policies.php
	Settings.php

6 lines

4 lines

UserProfile.php

PasswordResetTest.php

1 line

	PoliciesTest.php
	SettingsTest.php

28 lines

SettingsTest.php

262 lines

5 lines

UserProfileTest.php

158 lines

Diff 12365

src/app/Backends/IMAP.php

Loading...

src/app/Backends/LDAP.php

Loading...

src/resources/js/user/routes.js

Loading...

src/resources/lang/en/ui.php

Loading...

src/resources/lang/fr/ui.php

Loading...

src/resources/themes/app.scss

Loading...

src/resources/vue/Dashboard.vue

Loading...

src/resources/vue/Policies.vue

Loading...

src/resources/vue/Settings.vue

Loading...

src/resources/vue/User/Info.vue

Loading...

src/resources/vue/User/Profile.vue

Loading...

src/resources/vue/User/ProfileDelete.vue

Loading...

src/tests/Browser/DomainTest.php

Loading...

src/tests/Browser/LogonTest.php

Loading...

src/tests/Browser/Pages/Policies.php

Loading...

src/tests/Browser/Pages/Settings.php

Loading...

src/tests/Browser/Pages/UserInfo.php

Loading...

src/tests/Browser/Pages/UserProfile.php

Loading...

src/tests/Browser/PasswordResetTest.php

Loading...

src/tests/Browser/PoliciesTest.php

Loading...

src/tests/Browser/SettingsTest.php

Loading...

src/tests/Browser/SignupTest.php

Loading...

src/tests/Browser/UserProfileTest.php

Loading...

src/tests/Browser/UsersTest.php

Loading...