Differential D4208

./artisan status:health: check every backend instead of just one
ClosedPublic
Actions

Authored by mollekopf on Mar 27 2023, 10:30 AM.

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rKdb54b0f95107: ./artisan status:health: check every backend instead of just one

Diff Detail

Repository

rK kolab

Branch

dev/mollekopf

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/app/Console/Commands/Status/Health.php:158	phpstan	Variable $response might not be defined.

Unit

No Test Coverage

Build Status

Buildable 42164
Build 16997: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 27 2023, 10:30 AM

mollekopf created this revision.

Harbormaster completed remote builds in B42164: Diff 12056.Mar 27 2023, 10:30 AM

Fixup

Harbormaster completed remote builds in B42167: Diff 12062.Mar 27 2023, 10:32 AM

mollekopf added a reviewer: Restricted Project.Mar 27 2023, 11:33 AM

An improvement would be to print which backend failed. Also, we shouldn't var_export the whole response object, error code/message would be enough.

This revision is now accepted and ready to land.Mar 27 2023, 11:49 AM

Only print the status code and reason

Harbormaster completed remote builds in B42185: Diff 12080.Mar 27 2023, 12:03 PM

This revision was landed with ongoing or failed builds.Mar 27 2023, 2:43 PM

Closed by commit rKdb54b0f95107: ./artisan status:health: check every backend instead of just one (authored by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

Commands/

Status/

Health.php

20 lines

Diff 12056

View Options

src/app/Console/Commands/Status/Health.php

./artisan status:health: check every backend instead of just oneClosedPublicActions