Page MenuHomePhorge
Differential D4151

Added s3 dependency
ClosedPublic
Actions

Authored by mollekopf on Mar 11 2023, 12:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 3, 12:57 PM
Unknown Object (File)
Tue, Sep 17, 4:27 AM
Unknown Object (File)
Fri, Sep 13, 8:41 AM
Unknown Object (File)
Fri, Sep 13, 8:39 AM
Unknown Object (File)
Fri, Sep 13, 8:39 AM
Unknown Object (File)
Fri, Sep 13, 8:37 AM
Unknown Object (File)
Sep 1 2024, 12:17 AM
Unknown Object (File)
Aug 30 2024, 12:50 PM
View All 96 Files
Subscribers
machniak

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rK1e54630faca8: Added s3 dependency
rK35dcbd6de0bd: Added s3 dependency
rK2936aebbf5ce: Added s3 dependency
rKa4719d17b2b2: Added s3 dependency
rK94be59e08adf: Added s3 dependency
rKe11b25330d82: Added s3 dependency
rK6deb54f6dc77: Added s3 dependency
rKbaef77033f05: Added s3 dependency
rK36cac71480bc: Added s3 dependency

Diff Detail

Repository
rK kolab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41987
Build 16865: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 11 2023, 12:50 PM
mollekopf created this revision.
Harbormaster completed remote builds in B41987: Diff 11891.Mar 11 2023, 12:50 PM
mollekopf added a reviewer: Restricted Project.Mar 11 2023, 12:52 PM

The tests require some adjustment, that's currently in a separate commit (I can fix that before pushing).

machniak subscribed.Mar 13 2023, 12:24 PM

Makes sense, but please note that it will require some configuration when we deploy this change (as the default is 'local').

mollekopf added a comment.Mar 22 2023, 9:19 AM
In D4151#49970, @machniak wrote:

Makes sense, but please note that it will require some configuration when we deploy this change (as the default is 'local').

That's what FILESYSTEM_DISK=minio is for in the .env

machniak added a comment.Mar 22 2023, 9:27 AM

My point was that we're using this in production, so we need to migrate from local to minio or stay at local until we're ready to switch.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2023, 11:41 AM
Closed by commit rK1e54630faca8: Added s3 dependency (authored by mollekopf). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
3 lines
config.demo/
src/
4 lines
config.prod/
src/
5 lines
24 lines
src/
app/
Backends/
12 lines
1 line
config/
10 lines

Diff 11891

View Options

bin/quickstart.sh

Loading...
View Options

config.demo/src/.env

Loading...
View Options

config.prod/src/.env

Loading...
View Options

docker-compose.yml

Loading...
View Options

src/app/Backends/Storage.php

Loading...
View Options

src/composer.json

Loading...
View Options

src/config/filesystems.php

Loading...