Page MenuHomePhorge

Signup 'mandate' mode and other improvements
ClosedPublic

Authored by machniak on Mar 9 2023, 2:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 6:20 AM
Unknown Object (File)
Jan 27 2024, 10:23 PM
Unknown Object (File)
Jan 25 2024, 1:27 AM
Unknown Object (File)
Jan 24 2024, 3:10 PM
Unknown Object (File)
Jan 23 2024, 4:25 PM
Unknown Object (File)
Jan 23 2024, 4:24 PM
Unknown Object (File)
Jan 23 2024, 4:22 PM
Unknown Object (File)
Jan 23 2024, 2:38 PM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK396fcdf64940: Signup 'mandate' mode and other improvements
Summary

Plans.months
Wallet lock
Skip the payment method selection if there is only one option
Signup: Select the first domain if APP_DOMAIN is not on the list of public domains
Signup: Fallback to 'user' icon for unknown plans
Improve and test User::unrestrict(true)
Signup: Prefer monthly plans on left, yearly on right
Give themes more control over the menu
Allow themes to overwrite UI localization
Small improvement in loading theme localization
Improve menu localization mechanism
Support theme's fonts dir, fix fatal error in localization

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/signup-mandate-mode-diff
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 41933
Build 16838: arc lint + arc unit

Event Timeline

machniak created this revision.
mollekopf added inline comments.
src/app/Http/Controllers/API/SignupController.php
251

Shouldn't empty($request->code) && empty($request->invitation) be validation, and not silently send you into a different codepath?

src/app/User.php
564

includeWalletUsers or so would be better

src/database/migrations/2023_02_17_100000_vat_rates_table.php
81

Doesn't belong in the same commit (but is indeed required).

Looks good to me, with some minor comments

This revision is now accepted and ready to land.Mar 10 2023, 12:28 PM
This revision was automatically updated to reflect the committed changes.