Differential D3926

Configurable services domain
ClosedPublic
Actions

Authored by mollekopf on Oct 21 2022, 2:12 PM.

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rKf5078424db63: Mount the cyrus-imap directory
rKd0d6dbe44cb8: Configurable services domain

Diff Detail

Repository

rK kolab

Branch

dev/mollekopf

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/config/app.php:87	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

No Test Coverage

Build Status

Buildable 40463
Build 16385: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Oct 21 2022, 2:12 PM

mollekopf created this revision.

Harbormaster completed remote builds in B40460: Diff 11204.Oct 21 2022, 2:12 PM

Backwards compatibility

Harbormaster completed remote builds in B40463: Diff 11207.Oct 21 2022, 2:14 PM

line length

Harbormaster completed remote builds in B40466: Diff 11210.Oct 21 2022, 2:18 PM

This should resolve the following modification:

 if (\config('app.with_services')) {
     Route::group(
         [
-            'domain' => 'services.' . \config('app.website_domain'),
+            'domain' => 'services.infra.' . \config('app.website_domain'),
             'prefix' => 'webhooks'
         ],
         function () {