Page MenuHomePhorge

[Python 3] urllib.urlencode / httplib module change
ClosedPublic

Authored by ghane on Sep 30 2022, 2:08 PM.
Tags
None
Referenced Files
F11794524: D3878.id11036.diff
Thu, Apr 18, 6:02 PM
Unknown Object (File)
Wed, Apr 17, 1:21 PM
Unknown Object (File)
Wed, Apr 17, 9:48 AM
Unknown Object (File)
Thu, Apr 11, 10:43 AM
Unknown Object (File)
Tue, Apr 9, 8:57 PM
Unknown Object (File)
Tue, Apr 9, 9:50 AM
Unknown Object (File)
Sun, Apr 7, 10:09 AM
Unknown Object (File)
Wed, Apr 3, 1:12 PM
Subscribers

Details

Summary
try:
    import httplib
except ImportError:
    import http.client as httplib
try:
    from urlparse import urlparse
except ImportError:
    from urllib.parse import urlparse
try:
    from urllib import urlencode
except ImportError:
    from urllib.parse import urlencode

Diff Detail

Repository
rP pykolab
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ghane requested review of this revision.Sep 30 2022, 2:08 PM
ghane created this revision.
sicherha subscribed.

This is missing the import stuff, isn't it?

This revision now requires changes to proceed.Sep 30 2022, 2:17 PM
ghane retitled this revision from urllib.urlencode wrong variable to [Python 3] urllib.urlencode / httplib module change.
ghane edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 30 2022, 3:11 PM

The patch doesn't apply cleanly because the following hunk is already present on master:

try:
    import httplib
except ImportError:
    import http.client as httplib

Could you rebase the commit onto master?

This revision now requires changes to proceed.Sep 30 2022, 3:13 PM
This revision is now accepted and ready to land.Sep 30 2022, 5:04 PM
This revision was automatically updated to reflect the committed changes.