Page MenuHomekolab.org

[Python 3] urllib.urlencode / httplib module change
ClosedPublic

Authored by ghane on Sep 30 2022, 2:08 PM.

Details

Summary
try:
    import httplib
except ImportError:
    import http.client as httplib
try:
    from urlparse import urlparse
except ImportError:
    from urllib.parse import urlparse
try:
    from urllib import urlencode
except ImportError:
    from urllib.parse import urlencode

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ghane requested review of this revision.Sep 30 2022, 2:08 PM
ghane created this revision.
sicherha requested changes to this revision.Sep 30 2022, 2:17 PM
sicherha added a subscriber: sicherha.

This is missing the import stuff, isn't it?

This revision now requires changes to proceed.Sep 30 2022, 2:17 PM
ghane updated this revision to Diff 11036.Sep 30 2022, 2:55 PM
ghane retitled this revision from urllib.urlencode wrong variable to [Python 3] urllib.urlencode / httplib module change.
ghane edited the summary of this revision. (Show Details)
sicherha accepted this revision.Sep 30 2022, 3:11 PM
This revision is now accepted and ready to land.Sep 30 2022, 3:11 PM
sicherha requested changes to this revision.Sep 30 2022, 3:13 PM

The patch doesn't apply cleanly because the following hunk is already present on master:

try:
    import httplib
except ImportError:
    import http.client as httplib

Could you rebase the commit onto master?

This revision now requires changes to proceed.Sep 30 2022, 3:13 PM
ghane updated this revision to Diff 11042.Sep 30 2022, 4:03 PM
sicherha accepted this revision.Sep 30 2022, 5:04 PM
This revision is now accepted and ready to land.Sep 30 2022, 5:04 PM
This revision was automatically updated to reflect the committed changes.