Uploading Files to Subdirectories on seafile backends doesn't work
ClosedPublic
Actions

Authored by dhoffend on Mar 26 2022, 10:30 PM.

Details

Reviewers

machniak
mollekopf

Group Reviewers

Chwala Developers

Commits

rCd2ffd1b70b6a: Uploading Files to Subdirectories on seafile backends doesn't work

Summary

This patch fixes uploading for new files. Tested with Seafile 8.0 and 9.0.
It also removes some php warnings when fileapi_backend_storage_disabled is
disabled

Test Plan

Connect a Seafile storage. Create a SubDirectory and try to upload
a file.

Diff Detail

Repository

rC chwala

Branch

fix-seafile-upload

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 38755
Build 15715: arc lint + arc unit

Event Timeline

dhoffend requested review of this revision.Mar 26 2022, 10:30 PM

dhoffend created this revision.

Harbormaster completed remote builds in B38755: Diff 9946.Mar 26 2022, 10:30 PM

Here's the documentation to the current web api parameters for file uploads:
https://download.seafile.com/published/web-api/v2.1/file-upload.md

To make it work we've 2 ways: request upload link with parent_dir=/full/path and upload with relative_path= or request upload link with parent_dir=/ and upload with relative_path=full/path

I opted for the 2nd version to stay in line with the old way

dhoffend retitled this revision from Summary: Uploading Files to Subdirectories on seafile backends doesn't work to Uploading Files to Subdirectories on seafile backends doesn't work.Mar 26 2022, 10:50 PM

dhoffend added reviewers: machniak, mollekopf.May 10 2022, 10:42 PM

dhoffend added a project: Chwala.

mollekopf accepted this revision.Jul 7 2022, 12:16 PM

This revision is now accepted and ready to land.Jul 7 2022, 12:16 PM