Page MenuHomePhorge
Differential D3397

Laravel v9
AbandonedPublic
Actions

Authored by machniak on Feb 23 2022, 11:57 AM.
Tags
None
Referenced Files
F11906295: D3397.id9694.largetrue.diff
Fri, Apr 26, 6:04 PM
F11905674: D3397.id9712.largetrue.diff
Fri, Apr 26, 3:36 PM
Unknown Object (File)
Wed, Apr 24, 2:45 PM
Unknown Object (File)
Tue, Apr 23, 12:01 AM
Unknown Object (File)
Sun, Apr 21, 4:46 PM
Unknown Object (File)
Sun, Apr 21, 8:20 AM
Unknown Object (File)
Sat, Apr 20, 12:33 AM
Unknown Object (File)
Fri, Apr 19, 8:56 PM
View All 76 Files
Subscribers
Restricted Project

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rKf48a28151395: Cleanup and use of new Eloquent features
rKfae77c49eec0: Laravel v9
Summary

Migration to Laravel v9 + Octane, some cleanups

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/laravel-v9
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/config/cache.php:108PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceAfterPSR12.Operators.OperatorSpacing.NoSpaceAfter
Errorsrc/config/cache.php:108PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceBeforePSR12.Operators.OperatorSpacing.NoSpaceBefore
Errorsrc/config/filesystems.php:46PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceAfterPSR12.Operators.OperatorSpacing.NoSpaceAfter
Errorsrc/config/filesystems.php:46PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceBeforePSR12.Operators.OperatorSpacing.NoSpaceBefore
Errorsrc/config/logging.php:85PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceAfterPSR12.Operators.OperatorSpacing.NoSpaceAfter
Errorsrc/config/logging.php:85PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceAfterPSR12.Operators.OperatorSpacing.NoSpaceAfter
Errorsrc/config/logging.php:85PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceAfterPSR12.Operators.OperatorSpacing.NoSpaceAfter
Errorsrc/config/logging.php:85PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceBeforePSR12.Operators.OperatorSpacing.NoSpaceBefore
Errorsrc/config/logging.php:85PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceBeforePSR12.Operators.OperatorSpacing.NoSpaceBefore
Errorsrc/config/logging.php:85PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceBeforePSR12.Operators.OperatorSpacing.NoSpaceBefore
Errorsrc/config/session.php:131PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceAfterPSR12.Operators.OperatorSpacing.NoSpaceAfter
Errorsrc/config/session.php:131PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceBeforePSR12.Operators.OperatorSpacing.NoSpaceBefore
Errorsrc/public/index.php:6PHPCS.E.PSR12.Files.FileHeader.IncorrectOrderPSR12.Files.FileHeader.IncorrectOrder
Errorsrc/public/index.php:15PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceAfterPSR12.Operators.OperatorSpacing.NoSpaceAfter
Errorsrc/public/index.php:15PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceBeforePSR12.Operators.OperatorSpacing.NoSpaceBefore
Errorsrc/public/index.php:31PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceAfterPSR12.Operators.OperatorSpacing.NoSpaceAfter
Errorsrc/public/index.php:31PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceBeforePSR12.Operators.OperatorSpacing.NoSpaceBefore
Errorsrc/public/index.php:45PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceAfterPSR12.Operators.OperatorSpacing.NoSpaceAfter
Errorsrc/public/index.php:45PHPCS.E.PSR12.Operators.OperatorSpacing.NoSpaceBeforePSR12.Operators.OperatorSpacing.NoSpaceBefore
Warningsrc/routes/api.php:128PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warningsrc/routes/api.php:132PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Warningsrc/routes/api.php:252PHPCS.W.Generic.Files.LineLength.TooLongGeneric.Files.LineLength.TooLong
Unit
No Test Coverage
Build Status
Buildable 38509
Build 15559: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Feb 23 2022, 11:57 AM
machniak created this revision.
Harbormaster completed remote builds in B38509: Diff 9694.Feb 23 2022, 11:57 AM
Harbormaster completed remote builds in B38509: Diff 9694.
machniak updated this revision to Diff 9700.Feb 23 2022, 1:17 PM
  • Fix some linting issues
  • More code improvements
  • Merge branch 'dev/laravel-v9' of ssh://git.kolab.org/source/kolab into dev/laravel-v9
Harbormaster completed remote builds in B38515: Diff 9700.Feb 23 2022, 1:17 PM
machniak updated this revision to Diff 9712.Feb 24 2022, 10:05 AM
  • Cleanup and use of new Eloquent features
Harbormaster completed remote builds in B38521: Diff 9712.Feb 24 2022, 10:05 AM
machniak abandoned this revision.Feb 24 2022, 11:51 AM

Close in favour of D3409

Large Diff

This large diff affects 127 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
bin/
5 lines
docker/
swoole/
rootfs/
usr/
local/
bin/
2 lines
src/
5 lines
10 lines
3 lines
app/
Auth/
16 lines
Backends/
2 lines
3 lines
Console/
4 lines
Commands/
Data/
Import/
1 line
9 lines
2 lines
2 lines
17 lines
27 lines
7 lines
13 lines
Exceptions/
46 lines
9 lines
7 lines
Http/
Controllers/
API/
10 lines
25 lines
V4/
Admin/
2 lines
1 line
1 line
33 lines
Middleware/
2 lines
PreventRequestsDuringMaintenance.php
CheckForMaintenanceMode.php
6 lines
13 lines
20 lines
10 lines
9 lines
1 line
1 line
Jobs/
4 lines
4 lines
2 lines
2 lines
2 lines
Observers/
OpenVidu/
23 lines
OpenVidu/
4 lines
5 lines
2 lines
4 lines
1 line
2 lines
Providers/
14 lines
14 lines
1 line
64 lines
15 lines
7 lines
11 lines
7 lines
7 lines
36 lines
7 lines
4 lines
8 lines
7 lines
Traits/
2 lines
10 lines
30 lines
7 lines
12 lines
7 lines
38 lines
61 lines
7 lines
65 lines
config/
41 lines
2 lines
10 lines
9 lines
6 lines
34 lines
6 lines
41 lines
139 lines
222 lines
7 lines
22 lines
2 lines
2 lines
public/
11 lines
resources/
lang/
en/
1 line
22 lines
routes/
358 lines
2 lines
3 lines
9 lines
storage/
framework/
9 lines
tests/
Browser/
26 lines
1 line
2 lines
Feature/
Auth/
7 lines
7 lines
Console/
Data/
Import/
5 lines
Scalpel/
TenantSetting/
2 lines
WalletSetting/
2 lines
Controller/
45 lines
1 line
Jobs/
2 lines
7 lines
Stories/
1 line
1 line
25 lines
Unit/
Mail/
7 lines
11 lines
7 lines
7 lines
7 lines
7 lines
7 lines
7 lines
7 lines
7 lines
7 lines
7 lines
7 lines
7 lines

Diff 9694

View Options

bin/quickstart.sh

View Options

docker/swoole/rootfs/usr/local/bin/run-container

View Options

src/.env.example

View Options

src/.gitattributes

View Options

src/.styleci.yml

View Options

src/app/Auth/LDAPUserProvider.php

View Options

src/app/AuthAttempt.php

View Options

src/app/Backends/LDAP.php

View Options

src/app/CompanionApp.php

View Options

src/app/Console/Command.php

View Options

src/app/Console/Commands/Data/Import/LdifCommand.php

View Options

src/app/Console/Kernel.php

View Options

src/app/Console/ObjectCommand.php

View Options

src/app/Console/ObjectCreateCommand.php

View Options

src/app/Discount.php

View Options

src/app/Domain.php

View Options

src/app/DomainSetting.php

View Options

src/app/Entitlement.php

View Options

src/app/Exceptions/Handler.php

View Options

src/app/Group.php

View Options

src/app/GroupSetting.php

View Options

src/app/Http/Controllers/API/PasswordResetController.php

View Options

src/app/Http/Controllers/API/SignupController.php

View Options

src/app/Http/Controllers/API/V4/Admin/UsersController.php

View Options

src/app/Http/Controllers/API/V4/AuthAttemptsController.php

View Options

src/app/Http/Controllers/API/V4/WalletsController.php

View Options

src/app/Http/Kernel.php

View Options

src/app/Http/Middleware/CheckForMaintenanceMode.php

View Options

src/app/Http/Middleware/EncryptCookies.php

View Options

src/app/Http/Middleware/PreventRequestsDuringMaintenance.php

View Options

src/app/Http/Middleware/RedirectIfAuthenticated.php

View Options

src/app/Http/Middleware/TrustHosts.php

View Options

src/app/Http/Middleware/TrustProxies.php

View Options

src/app/Http/Middleware/VerifyCsrfToken.php

View Options

src/app/IP4Net.php

View Options

src/app/IP6Net.php

View Options

src/app/Jobs/PaymentEmail.php

View Options

src/app/Jobs/PaymentMandateDisabledEmail.php

View Options

src/app/Jobs/SignupInvitationEmail.php

View Options

src/app/Jobs/WalletCharge.php

View Options

src/app/Jobs/WalletCheck.php

View Options

src/app/Observers/OpenVidu/ConnectionObserver.php

View Options

src/app/OpenVidu/Room.php

View Options

src/app/Package.php

View Options

src/app/PackageSku.php

View Options

src/app/Payment.php

View Options

src/app/Plan.php

View Options

src/app/PlanPackage.php

View Options

src/app/Providers/AuthServiceProvider.php

View Options

src/app/Providers/EventServiceProvider.php

View Options

src/app/Providers/PassportServiceProvider.php

View Options

src/app/Providers/RouteServiceProvider.php

View Options

src/app/Resource.php

View Options

src/app/ResourceSetting.php

View Options

src/app/SharedFolder.php

View Options

src/app/SharedFolderAlias.php

View Options

src/app/SharedFolderSetting.php

View Options

src/app/SignupCode.php

View Options

src/app/SignupInvitation.php

View Options

src/app/Sku.php

View Options

src/app/Tenant.php

View Options

src/app/TenantSetting.php

View Options

src/app/Traits/EmailPropertyTrait.php

View Options

src/app/Transaction.php

View Options

src/app/User.php

View Options

src/app/UserAlias.php

View Options

src/app/UserPassword.php

View Options

src/app/UserSetting.php

View Options

src/app/VerificationCode.php

View Options

src/app/Wallet.php

View Options

src/app/WalletSetting.php

View Options

src/composer.json

View Options

src/config/app.php

View Options

src/config/auth.php

View Options

src/config/broadcasting.php

View Options

src/config/cache.php

View Options

src/config/database.php

View Options

src/config/filesystems.php

View Options

src/config/hashing.php

View Options

src/config/logging.php

View Options

src/config/mail.php

View Options

src/config/octane.php

View Options

src/config/queue.php

View Options

src/config/session.php

View Options

src/config/swoole_http.php

View Options

src/config/swoole_websocket.php

View Options

src/phpstan.neon

View Options

src/phpunit.xml

View Options

src/public/index.php

View Options

src/resources/lang/en/auth.php

View Options

src/resources/lang/en/validation.php

View Options

src/routes/api.php

View Options

src/routes/channels.php

View Options

src/routes/console.php

View Options

src/routes/web.php

View Options

src/routes/websocket.php

View Options

src/storage/framework/.gitignore

View Options

src/tests/Browser/DomainTest.php

View Options

src/tests/Browser/ErrorTest.php

View Options

src/tests/Browser/SharedFolderTest.php

View Options

src/tests/Feature/Auth/SecondFactorTest.php

View Options

src/tests/Feature/AuthAttemptTest.php

View Options

src/tests/Feature/Console/Data/Import/LdifTest.php

View Options

src/tests/Feature/Console/Scalpel/TenantSetting/CreateCommandTest.php

View Options

src/tests/Feature/Console/Scalpel/WalletSetting/CreateCommandTest.php

View Options

src/tests/Feature/Controller/SupportTest.php

View Options

src/tests/Feature/Controller/UsersTest.php

View Options

src/tests/Feature/Jobs/PasswordResetEmailTest.php

View Options

src/tests/Feature/SkuTest.php

View Options

src/tests/Feature/Stories/GreylistTest.php

View Options

src/tests/Feature/TenantTest.php

View Options

src/tests/MailInterceptTrait.php

View Options

src/tests/TestCaseTrait.php

View Options

src/tests/Unit/Mail/DegradedAccountReminderTest.php

View Options

src/tests/Unit/Mail/NegativeBalanceBeforeDeleteTest.php

View Options

src/tests/Unit/Mail/NegativeBalanceDegradedTest.php

View Options

src/tests/Unit/Mail/NegativeBalanceReminderDegradeTest.php

View Options

src/tests/Unit/Mail/NegativeBalanceReminderTest.php

View Options

src/tests/Unit/Mail/NegativeBalanceSuspendedTest.php

View Options

src/tests/Unit/Mail/NegativeBalanceTest.php

View Options

src/tests/Unit/Mail/PasswordResetTest.php

View Options

src/tests/Unit/Mail/PaymentFailureTest.php

View Options

src/tests/Unit/Mail/PaymentMandateDisabledTest.php

View Options

src/tests/Unit/Mail/PaymentSuccessTest.php

View Options

src/tests/Unit/Mail/SignupInvitationTest.php

View Options

src/tests/Unit/Mail/SignupVerificationTest.php

View Options

src/tests/Unit/Mail/SuspendedDebtorTest.php