Page MenuHomePhorge

T1988: Fix performance issue in check_event_conflict()
AbandonedPublic

Authored by vanmeeuwen on Nov 24 2016, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 24 2024, 10:15 AM
Unknown Object (File)
Jan 22 2024, 4:33 PM
Unknown Object (File)
Jan 15 2024, 5:46 PM
Unknown Object (File)
Jan 15 2024, 10:23 AM
Unknown Object (File)
Dec 30 2023, 11:06 PM
Unknown Object (File)
Dec 23 2023, 7:41 PM
Unknown Object (File)
Dec 21 2023, 5:08 AM
Unknown Object (File)
Dec 16 2023, 5:19 AM
Subscribers
None

Details

Summary

When comparing two weekly events with infinite recursion, the method
can take (almost) forever. In such a case it does 10 * 50 * 10 * 50
iterations which are expensive.

The fix workarounds the issue by limiting number of iterations, i.e.
we do not loop over all occurrences of the second event, but only take
those in time period of the main event occurence.

Fixes T1988

Diff Detail

Repository
rP pykolab
Branch
dev/T1988
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6854
Build 6992: arc lint + arc unit

Event Timeline

machniak retitled this revision from to T1988: Fix performance issue in check_event_conflict().
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen abandoned this revision.
vanmeeuwen added a reviewer: machniak.