Page MenuHomekolab.org

Add artisan owner:swap command
ClosedPublic

Authored by machniak on Fri, Oct 1, 4:13 PM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK86ea94306654: Add artisan owner:swap command
Test Plan

./phpunit tests/Feature/Console/OwnerSwapTest.php

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Fri, Oct 1, 4:13 PM
machniak created this revision.
machniak updated this revision to Diff 8354.Fri, Oct 1, 4:18 PM
  • Add todo comment
machniak updated this revision to Diff 8360.Mon, Oct 4, 9:01 AM
  • Update mollie customer email/name on owner swap
mollekopf accepted this revision.Wed, Oct 6, 9:51 AM
mollekopf added a subscriber: mollekopf.

Looks good.

Notes (no blockers I think):

  • The wallet description is not copied
  • It's not clear to me why the targetWallet needs to be one month old, perhaps add a comment.
  • The "same account" check is a bit obscure and would deserve a dedicated method I think: User::controlledBySameWallet($users)
This revision is now accepted and ready to land.Wed, Oct 6, 9:51 AM
This revision was automatically updated to reflect the committed changes.