Add artisan owner:swap command
ClosedPublic
Actions

Authored by machniak on Oct 1 2021, 4:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 25, 3:45 PM

	Unknown Object (File)
	Thu, Nov 16, 12:07 AM

	Unknown Object (File)
	Wed, Nov 8, 1:37 PM

	Unknown Object (File)
	Nov 2 2023, 9:35 AM

	Unknown Object (File)
	Nov 1 2023, 4:23 AM

	Unknown Object (File)
	Oct 27 2023, 3:35 AM

	Unknown Object (File)
	Oct 26 2023, 2:57 AM

	Unknown Object (File)
	Oct 25 2023, 2:10 AM

Subscribers

Restricted Project

Details

Reviewers

mollekopf

Group Reviewers

Restricted Project

Commits

rK86ea94306654: Add artisan owner:swap command

Test Plan

./phpunit tests/Feature/Console/OwnerSwapTest.php

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

machniak requested review of this revision.Oct 1 2021, 4:13 PM

machniak created this revision.

Looks good.

Notes (no blockers I think):

The wallet description is not copied
It's not clear to me why the targetWallet needs to be one month old, perhaps add a comment.
The "same account" check is a bit obscure and would deserve a dedicated method I think: User::controlledBySameWallet($users)

This revision is now accepted and ready to land.Oct 6 2021, 9:51 AM

This revision was automatically updated to reflect the committed changes.