Page MenuHomekolab.org

Fix memory bugs
ClosedPublic

Authored by sicherha on Mon, May 24, 3:06 PM.

Details

Summary

This revision comprises a patch that fixes potential access to dangling
pointers, and one that plugs a bunch of memory leaks in the tests.

Fix dangling pointers

std::vector gives zero guarantees that pointers to its elements remain
valid when the vector's size changes. In particular, pushing new
elements into the vector may trigger reallocation of the underlying heap
area.

Consequently, Event::delegate() needs to ensure that any modifications
to the d->attendees vector are performed before pointers to its elements
are taken and collected.

Found with Valgrind.

Fix use-after-free bug

QByteArray::fromRawData() does not copy the contents of the source
buffer. If the resulting QByteArray object lives longer than the source
buffer, we run into use-after-free problems.

In this particular instance, the source data resides in a temporary
rvalue object.

Diff Detail

Repository
rLK libkolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sicherha requested review of this revision.Mon, May 24, 3:06 PM
sicherha created this revision.
sicherha edited the summary of this revision. (Show Details)
mollekopf accepted this revision.Mon, May 24, 6:41 PM

Looks reasonable, thanks for the patch.

Commit preferably as two separate patches.

This revision is now accepted and ready to land.Mon, May 24, 6:41 PM

Hmm, does Arcanist offer a way to do fast-forward merges?

--strategy squash would squash my two commits into one.
--strategy merge would create a merge commit, which seems a bit excessive.

This revision was automatically updated to reflect the committed changes.