Differential D212

trigger an event when modal calendar edit/new event is rendered
ClosedPublic
Actions

Authored by fabioperrella on Aug 29 2016, 1:53 PM.

Details

Reviewers

machniak

Commits

rRPK9533b219acd9: trigger an event when modal calendar edit/new event is rendered

Summary

to help customize the modal behavior, trigger an event when modal rendering is done

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

fabioperrella updated this revision to Diff 460.Aug 29 2016, 1:53 PM

fabioperrella retitled this revision from to trigger an event when modal calendar edit/new event is rendered.

fabioperrella updated this object.

fabioperrella edited the test plan for this revision. (Show Details)

fabioperrella set the repository for this revision to rRPK roundcubemail-plugins-kolab.

fabioperrella added a reviewer: machniak.Sep 8 2016, 3:19 PM

I propose to name the event "calendar-event-dialog" and add dialog: $dialog argument. See also D218.

This revision now requires changes to proceed.Sep 26 2016, 1:26 PM

machniak mentioned this in D218: Trigger an event when modal calendar show event is rendered.Sep 26 2016, 1:26 PM

I agree to add $dialog as arg, but what about renaming to "calendar-event-dialog-finish" or "calendar-event-dialog-end" ? The reason is today there is another hook called "calendar-event-init" in the beginning of the method "event_show_dialog"

Well, there's code that is executed async when opening the dialog, so -finish/-end is not exactly true when you trigger the event. That's why I prefer a name without such a suffix.