trigger an event when modal calendar edit/new event is rendered

Authored by fabioperrella on Aug 29 2016, 1:53 PM.



to help customize the modal behavior, trigger an event when modal rendering is done

Diff Detail

rRPK roundcubemail-plugins-kolab
Lint Skipped
Unit Tests Skipped

Event Timeline

fabioperrella retitled this revision from to trigger an event when modal calendar edit/new event is rendered.
fabioperrella updated this object.
fabioperrella edited the test plan for this revision. (Show Details)
fabioperrella set the repository for this revision to rRPK roundcubemail-plugins-kolab.
machniak requested changes to this revision.Sep 26 2016, 1:26 PM
machniak edited edge metadata.

I propose to name the event "calendar-event-dialog" and add dialog: $dialog argument. See also D218.

This revision now requires changes to proceed.Sep 26 2016, 1:26 PM

I agree to add $dialog as arg, but what about renaming to "calendar-event-dialog-finish" or "calendar-event-dialog-end" ? The reason is today there is another hook called "calendar-event-init" in the beginning of the method "event_show_dialog"

Well, there's code that is executed async when opening the dialog, so -finish/-end is not exactly true when you trigger the event. That's why I prefer a name without such a suffix.

fabioperrella updated this revision to Diff 514.Oct 4 2016, 1:31 AM
fabioperrella edited edge metadata.
fabioperrella removed rRPK roundcubemail-plugins-kolab as the repository for this revision.

ok, I changed to the way you told to

machniak accepted this revision.Oct 4 2016, 1:45 PM
machniak edited edge metadata.
This revision is now accepted and ready to land.Oct 4 2016, 1:45 PM
This revision was automatically updated to reflect the committed changes.