T1414: Set LDAP TIMEOUT option only on "immediate" connection
ClosedPublic
Actions

Authored by machniak on Aug 18 2016, 12:18 PM.

Project Tags

None

Referenced Files

	F117781471: D208.1775248541.diff
	Thu, Apr 2, 8:35 PM

	F117763272: D208.1775219066.diff
	Thu, Apr 2, 12:24 PM

Subscribers

pokorra

thozie

Details

Reviewers

vanmeeuwen

Group Reviewers

PyKolab Developers

Maniphest Tasks

T1414: Kolabd not catching changes in LDAP

Commits

rP764103053f06: T1414: Set LDAP TIMEOUT option only on "immediate" connection
rP54cb493d655b: T1414: Set LDAP TIMEOUT option only on "immediate" connection

Summary

Fixes T1414.

Shouldn't we handle ldap.TIMEOUT exception in authenticate()?

Diff Detail

Repository

rP pykolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 455.Aug 18 2016, 12:18 PM

machniak retitled this revision from to T1414: Set LDAP TIMEOUT option only on "immediate" connection.

machniak updated this object.

machniak edited the test plan for this revision. (Show Details)

machniak added a reviewer: PyKolab Developers.

machniak added a task: T1414: Kolabd not catching changes in LDAP.

Fixed default for immediate argument of connect()

This fix works but is yet not integrated in Winterfell. On every update I have to Change it manually...

I have added the patch to Winterfell now.

vanmeeuwen accepted this revision.Oct 6 2016, 7:37 AM

vanmeeuwen added a reviewer: vanmeeuwen.

This revision is now accepted and ready to land.Oct 6 2016, 7:37 AM

Closed by commit rP54cb493d655b: T1414: Set LDAP TIMEOUT option only on "immediate" connection (authored by machniak, committed by vanmeeuwen). · Explain WhyOct 6 2016, 9:38 AM

This revision was automatically updated to reflect the committed changes.

vendel.colja mentioned this in T1307: make pykolab synchronize queueing mechanism reliable.Oct 11 2016, 11:45 AM

Revision Contents
Changeset List

Path

Size

pykolab/

auth/

ldap/

__init__.py

lines

Diff 550

View Options

T1414: Set LDAP TIMEOUT option only on "immediate" connectionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 550

pykolab/auth/ldap/__init__.py

T1414: Set LDAP TIMEOUT option only on "immediate" connection
ClosedPublic
Actions

Revision Contents
Changeset List

pykolab/auth/ldap/init.py