Page MenuHomePhorge
Differential D208

T1414: Set LDAP TIMEOUT option only on "immediate" connection
ClosedPublic
Actions

Authored by machniak on Aug 18 2016, 2:18 PM.
Tags
None
Referenced Files
F11884692: D208.diff
Wed, Apr 24, 3:17 PM
Unknown Object (File)
Mon, Apr 22, 9:35 AM
Unknown Object (File)
Sun, Apr 21, 11:35 AM
Unknown Object (File)
Sun, Apr 21, 11:09 AM
Unknown Object (File)
Sun, Apr 21, 10:57 AM
Unknown Object (File)
Tue, Apr 16, 6:21 PM
Unknown Object (File)
Sun, Apr 14, 10:14 PM
Unknown Object (File)
Mon, Apr 8, 6:17 AM
View All Files
Subscribers
pokorra
thozie

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Maniphest Tasks
T1414: Kolabd not catching changes in LDAP
Commits
rP764103053f06: T1414: Set LDAP TIMEOUT option only on "immediate" connection
rP54cb493d655b: T1414: Set LDAP TIMEOUT option only on "immediate" connection
Summary

Fixes T1414.

Shouldn't we handle ldap.TIMEOUT exception in authenticate()?

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 455.Aug 18 2016, 2:18 PM
machniak retitled this revision from to T1414: Set LDAP TIMEOUT option only on "immediate" connection.
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
machniak added a task: T1414: Kolabd not catching changes in LDAP.
machniak updated this revision to Diff 469.Sep 9 2016, 2:23 PM

Fixed default for immediate argument of connect()

thozie subscribed.Oct 3 2016, 8:51 AM

This fix works but is yet not integrated in Winterfell. On every update I have to Change it manually...

pokorra subscribed.Oct 5 2016, 6:23 PM

I have added the patch to Winterfell now.

vanmeeuwen accepted this revision.Oct 6 2016, 9:37 AM
vanmeeuwen added a reviewer: vanmeeuwen.
This revision is now accepted and ready to land.Oct 6 2016, 9:37 AM
Closed by commit rP54cb493d655b: T1414: Set LDAP TIMEOUT option only on "immediate" connection (authored by machniak, committed by vanmeeuwen). · Explain WhyOct 6 2016, 11:38 AM
This revision was automatically updated to reflect the committed changes.
vendel.colja mentioned this in T1307: make pykolab synchronize queueing mechanism reliable.Oct 11 2016, 1:45 PM

Revision Contents
Changeset List

PathSize
pykolab/
auth/
ldap/
5 lines

Diff 550

View Options

pykolab/auth/ldap/__init__.py

Loading...