Page MenuHomePhorge
Differential D2044

Join video conference by pressing return key
ClosedPublic
Actions

Authored by machniak on Jan 6 2021, 3:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 11:39 PM
Unknown Object (File)
Sat, Mar 30, 3:24 AM
Unknown Object (File)
Thu, Mar 28, 7:19 PM
Unknown Object (File)
Mar 22 2024, 5:46 AM
Unknown Object (File)
Mar 15 2024, 9:09 AM
Unknown Object (File)
Feb 23 2024, 10:53 AM
Unknown Object (File)
Feb 8 2024, 9:10 PM
Unknown Object (File)
Jan 18 2024, 7:54 PM
View All 16 Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKc99f41506b62: Join video conference by pressing return key
Summary

Also make some assertions resistent to timing issues

Test Plan

./phpunit --testsuite=Browser

Diff Detail

Repository
rK kolab
Branch
dev/join-room-with-enter
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32464
Build 12514: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jan 6 2021, 3:21 PM
machniak created this revision.
Harbormaster completed remote builds in B32464: Diff 5659.Jan 6 2021, 3:21 PM
vanmeeuwen accepted this revision.Jan 7 2021, 10:43 AM
This revision is now accepted and ready to land.Jan 7 2021, 10:43 AM
Closed by commit rKc99f41506b62: Join video conference by pressing return key (authored by machniak, committed by vanmeeuwen). · Explain WhyJan 7 2021, 10:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
resources/
vue/
Meet/
11 lines
tests/
8 lines
Browser/
Meet/
24 lines
14 lines
20 lines

Diff 5659

View Options

src/resources/vue/Meet/Room.vue

Loading...
View Options

src/tests/Browser.php

Loading...
View Options

src/tests/Browser/Meet/RoomControlsTest.php

Loading...
View Options

src/tests/Browser/Meet/RoomSecurityTest.php

Loading...
View Options

src/tests/Browser/Meet/RoomSetupTest.php

Loading...