Page MenuHomePhorge

Provide a minimal approach to the new command structures
ClosedPublic

Authored by vanmeeuwen on Dec 23 2020, 11:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 4:59 AM
Unknown Object (File)
Tue, Mar 19, 5:26 PM
Unknown Object (File)
Tue, Mar 19, 2:50 PM
Unknown Object (File)
Mon, Mar 18, 1:48 AM
Unknown Object (File)
Sun, Mar 17, 5:31 PM
Unknown Object (File)
Tue, Mar 12, 10:31 AM
Unknown Object (File)
Thu, Mar 7, 4:12 PM
Unknown Object (File)
Thu, Mar 7, 2:55 PM
Subscribers
Restricted Project

Details

Summary

This doesn't change any of the existing commands, making the overall approach more dense for clarity.

Test Plan

None

Diff Detail

Repository
rK kolab
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32206
Build 12358: arc lint + arc unit

Event Timeline

vanmeeuwen created this revision.
  • Also test if the command even has an option --with-deleted
  • Remove redundant object retrieval
  • Modify how the signature for ObjectListCommand is built
machniak subscribed.
machniak added inline comments.
src/app/Console/Commands/DomainsCommand.php
23

How to get multiple attributes might be not obvious for outsiders. The example should use two attributes.

src/app/Console/ObjectReadCommand.php
37

How about an error message here?

src/app/Console/ObjectUpdateCommand.php
75

An error message here.

86

We should make sure this timestamps=false really works.

This revision now requires changes to proceed.Dec 31 2020, 12:32 PM
vanmeeuwen marked 3 inline comments as done.
vanmeeuwen added inline comments.
src/app/Console/ObjectUpdateCommand.php
86

It doesn't :/

It's a laravel 8.x-ism i think.

This revision is now accepted and ready to land.Dec 31 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.
This revision is now accepted and ready to land.Jan 3 2021, 2:46 PM
  • Work around database logic not being available
This revision was automatically updated to reflect the committed changes.