Page MenuHomekolab.org

Provide a minimal approach to the new command structures
ClosedPublic

Authored by vanmeeuwen on Dec 23 2020, 11:27 AM.

Details

Summary

This doesn't change any of the existing commands, making the overall approach more dense for clarity.

Test Plan

None

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vanmeeuwen requested review of this revision.Dec 23 2020, 11:27 AM
vanmeeuwen created this revision.
vanmeeuwen updated this revision to Diff 5440.Dec 23 2020, 11:50 AM
  • Also test if the command even has an option --with-deleted
vanmeeuwen updated this revision to Diff 5446.Dec 23 2020, 12:07 PM
  • Remove redundant object retrieval
  • Modify how the signature for ObjectListCommand is built
machniak requested changes to this revision.Dec 31 2020, 12:32 PM
machniak added a subscriber: machniak.
machniak added inline comments.
src/app/Console/Commands/DomainsCommand.php
24

How to get multiple attributes might be not obvious for outsiders. The example should use two attributes.

src/app/Console/ObjectReadCommand.php
38

How about an error message here?

src/app/Console/ObjectUpdateCommand.php
76

An error message here.

87

We should make sure this timestamps=false really works.

This revision now requires changes to proceed.Dec 31 2020, 12:32 PM
vanmeeuwen planned changes to this revision.Dec 31 2020, 12:56 PM
vanmeeuwen marked 3 inline comments as done.
vanmeeuwen added inline comments.
src/app/Console/ObjectUpdateCommand.php
87

It doesn't :/

It's a laravel 8.x-ism i think.

vanmeeuwen updated this revision to Diff 5596.Dec 31 2020, 12:58 PM
  • Update from commentary
machniak accepted this revision.Dec 31 2020, 1:09 PM
This revision is now accepted and ready to land.Dec 31 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.
vanmeeuwen reopened this revision.Jan 3 2021, 2:46 PM
This revision is now accepted and ready to land.Jan 3 2021, 2:46 PM
vanmeeuwen updated this revision to Diff 5632.Jan 3 2021, 2:46 PM
  • Work around database logic not being available
This revision was automatically updated to reflect the committed changes.