Project Tags

None

Referenced Files

	F117744564: D1996.1775170220.diff
	Wed, Apr 1, 10:50 PM

	F117740278: D1996.1775160180.diff
	Wed, Apr 1, 8:03 PM

	F117739408: D1996.1775158360.diff
	Wed, Apr 1, 7:32 PM

	F117736438: D1996.1775149920.diff
	Wed, Apr 1, 5:12 PM

Subscribers

machniak

Restricted Project

Details

Reviewers

machniak

Group Reviewers

Restricted Project

Commits

rKa27c7a2e6511: Provide a minimal approach to the new command structures
rKa9ef3b57d38f: Provide a minimal approach to the new command structures
rKa960207d2d9d: Provide a minimal approach to the new command structures

Summary

This doesn't change any of the existing commands, making the overall approach more dense for clarity.

Test Plan

None

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vanmeeuwen requested review of this revision.Dec 23 2020, 10:27 AM

vanmeeuwen created this revision.

Harbormaster completed remote builds in B32194: Diff 5434.Dec 23 2020, 10:28 AM

Also test if the command even has an option --with-deleted

Harbormaster completed remote builds in B32200: Diff 5440.Dec 23 2020, 10:50 AM

Remove redundant object retrieval
Modify how the signature for ObjectListCommand is built

Harbormaster completed remote builds in B32206: Diff 5446.Dec 23 2020, 11:08 AM

machniak requested changes to this revision.Dec 31 2020, 11:32 AM

machniak subscribed.

machniak added inline comments.

src/app/Console/Commands/DomainsCommand.php
24	How to get multiple attributes might be not obvious for outsiders. The example should use two attributes.
src/app/Console/ObjectReadCommand.php
38	How about an error message here?
src/app/Console/ObjectUpdateCommand.php
76	An error message here.
87	We should make sure this timestamps=false really works.

This revision now requires changes to proceed.Dec 31 2020, 11:32 AM

vanmeeuwen planned changes to this revision.Dec 31 2020, 11:56 AM

vanmeeuwen marked 3 inline comments as done.

vanmeeuwen added inline comments.

src/app/Console/ObjectUpdateCommand.php
87	It doesn't :/ It's a laravel 8.x-ism i think.

Update from commentary

Harbormaster completed remote builds in B32359: Diff 5596.Dec 31 2020, 11:58 AM

machniak accepted this revision.Dec 31 2020, 12:09 PM

This revision is now accepted and ready to land.Dec 31 2020, 12:09 PM

Closed by commit rKa960207d2d9d: Provide a minimal approach to the new command structures. · Explain WhyDec 31 2020, 12:33 PM

This revision was automatically updated to reflect the committed changes.

vanmeeuwen reopened this revision.Jan 3 2021, 1:46 PM

This revision is now accepted and ready to land.Jan 3 2021, 1:46 PM

Work around database logic not being available

Harbormaster completed remote builds in B32416: Diff 5632.Jan 3 2021, 1:46 PM

Closed by commit rKa27c7a2e6511: Provide a minimal approach to the new command structures. · Explain WhyJan 3 2021, 1:47 PM

This revision was automatically updated to reflect the committed changes.

Provide a minimal approach to the new command structuresClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5635

bin/doctum

src/app/Console/Command.php

src/app/Console/Commands/DiscountsCommand.php

src/app/Console/Commands/DomainsCommand.php

src/app/Console/Commands/EntitlementsCommand.php

src/app/Console/Commands/PackagesCommand.php

src/app/Console/Commands/PlansCommand.php

src/app/Console/Commands/Scalpel/Discount/CreateCommand.php

src/app/Console/Commands/Scalpel/Discount/ReadCommand.php

src/app/Console/Commands/Scalpel/Domain/CreateCommand.php

src/app/Console/Commands/Scalpel/Domain/ReadCommand.php

src/app/Console/Commands/Scalpel/Domain/UpdateCommand.php

src/app/Console/Commands/Scalpel/Entitlement/CreateCommand.php

src/app/Console/Commands/Scalpel/Entitlement/ReadCommand.php

src/app/Console/Commands/Scalpel/Entitlement/UpdateCommand.php

src/app/Console/Commands/Scalpel/Package/ReadCommand.php

src/app/Console/Commands/Scalpel/Plan/ReadCommand.php

src/app/Console/Commands/Scalpel/Sku/ReadCommand.php

src/app/Console/Commands/Scalpel/Transaction/ReadCommand.php

src/app/Console/Commands/Scalpel/User/CreateCommand.php

src/app/Console/Commands/Scalpel/User/ReadCommand.php

src/app/Console/Commands/Scalpel/UserSetting/ReadCommand.php

src/app/Console/Commands/Scalpel/Wallet/ReadCommand.php

src/app/Console/Commands/Scalpel/WalletSetting/ReadCommand.php

src/app/Console/Commands/TransactionsCommand.php

src/app/Console/Commands/UserSettingsCommand.php

src/app/Console/Commands/UsersCommand.php

src/app/Console/Commands/WalletSettingsCommand.php

src/app/Console/Commands/WalletsCommand.php

src/app/Console/ObjectCommand.php

src/app/Console/ObjectCreateCommand.php

src/app/Console/ObjectListCommand.php

src/app/Console/ObjectReadCommand.php

src/app/Console/ObjectRelationListCommand.php

src/app/Console/ObjectUpdateCommand.php

Provide a minimal approach to the new command structures
ClosedPublic
Actions

Revision Contents
Changeset List