Make counters on tasklist filters consistent (#5470)
ClosedPublic
Actions

Authored by machniak on Jul 2 2016, 12:52 PM.

Details

Reviewers

petersen
vanmeeuwen

Group Reviewers

Roundcube Kolab Plugins Developers

Commits

rRPK7cde786c4e77: Make counters on tasklist filters consistent (#5470)
rRPKbdcba0979695: Make counters on tasklist filters consistent (#5470)

Summary

This implements my proposition from https://issues.kolab.org/show_bug.cgi?id=5470#c4

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Branch

dev/#5470

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4104
Build 4093: arc lint + arc unit

Event Timeline

machniak updated this revision to Diff 429.Jul 2 2016, 12:52 PM

machniak retitled this revision from to Make counters on tasklist filters consistent (#5470).

machniak updated this object.

machniak edited the test plan for this revision. (Show Details)

machniak added a reviewer: Roundcube Kolab Plugins Developers.

adding those file versions to our currently installed KE14 roundcubemail 1.1.5.21 roundcubemail-plugin-tasklist 3.2.15-4.1.el6.kolab_14 ends up in this error message:

[21-Sep-2016 11:48:54 Europe/Berlin] PHP Fatal error:  Call to undefined method kolab_storage_config::apply_links() in /usr/share/roundcubemail/plugins/tasklist/drivers/kolab/tasklist_kolab_driver.php on line 604

So we can't test it. Do those changes suite on kolab enterprise 14 on REL6 roundcube and plugins?

In D195#3134, @vendel.colja wrote:
adding those file versions to our currently installed KE14 roundcubemail 1.1.5.21 roundcubemail-plugin-tasklist 3.2.15-4.1.el6.kolab_14 ends up in this error message:
[21-Sep-2016 11:48:54 Europe/Berlin] PHP Fatal error:  Call to undefined method kolab_storage_config::apply_links() in /usr/share/roundcubemail/plugins/tasklist/drivers/kolab/tasklist_kolab_driver.php on line 604
So we can't test it. Do those changes suite on kolab enterprise 14 on REL6 roundcube and plugins?

This revision now requires changes to proceed.Oct 3 2016, 3:38 PM

No, it does not require changes! Putting the files from master into KE14 can't just work.

ps. I can't reset the revision state, so it will wait for a review as it is. If I don't get a review in a week I will ignore review process for this repository and commit my changes without review directly.

vanmeeuwen accepted this revision.Oct 3 2016, 3:59 PM

vanmeeuwen added a reviewer: vanmeeuwen.

Closed by commit rRPKbdcba0979695: Make counters on tasklist filters consistent (#5470) (authored by machniak, committed by vanmeeuwen). · Explain WhyOct 3 2016, 3:59 PM

This revision was automatically updated to reflect the committed changes.