Page MenuHomekolab.org

fix crash in capabilities response handling, and don't touch the response here
ClosedPublic

Authored by seigo on Jun 20 2016, 4:58 PM.

Details

Summary

the explicit capabilities command is multiline, so it produces a list response,
and eimap should not touch the incoming response, but leave that to the application.

Diff Detail

Repository
rEI eimap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seigo updated this revision to Diff 410.Jun 20 2016, 4:58 PM
seigo retitled this revision from to fix crash in capabilities response handling, and don't touch the response here.
seigo updated this object.
seigo edited the test plan for this revision. (Show Details)
seigo added a reviewer: Restricted Project.

This fixes the crash just fine.

It doesn't resolve the remaining or resulting problems though, of missing STARTTLS in the capabilities needing to be exposed to the client, especially since the chunk of code here seems to be interested more in posttls_capabilities (which shouldn't have STARTTLS to begin with?), whereas what I suppose we also need to fix is handling pretls_capabilities.

This revision was automatically updated to reflect the committed changes.