Page MenuHomePhorge

Restructure user and domain jobs
ClosedPublic

Authored by vanmeeuwen on Oct 7 2020, 2:38 PM.
Tags
None
Referenced Files
F11589471: D1720.id4600.diff
Thu, Mar 28, 11:08 PM
F11588760: D1720.id4606.diff
Thu, Mar 28, 9:10 PM
Unknown Object (File)
Wed, Mar 27, 11:40 PM
Unknown Object (File)
Fri, Mar 22, 3:11 AM
Unknown Object (File)
Sat, Mar 16, 9:31 AM
Unknown Object (File)
Sun, Mar 10, 11:55 AM
Unknown Object (File)
Tue, Mar 5, 10:22 PM
Unknown Object (File)
Tue, Mar 5, 10:22 PM
Subscribers
Restricted Project

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKe53988be889e: Restructure user and domain jobs
Summary

Also adds doctum

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vanmeeuwen created this revision.
machniak requested changes to this revision.Oct 7 2020, 2:57 PM
machniak subscribed.
machniak added inline comments.
src/app/Http/Controllers/API/V4/UsersController.php
597โ€“598

This will have to call fresh()/refresh() on the $user.

604โ€“605

This will have to call fresh()/refresh() on the $user.

src/app/Jobs/Domain/UpdateJob.php
19

The same as in User/UpdateJob, we should check if the domain isLdapReady() here, and maybe if it's not deleted/trashed(). Actually all domain jobs should check if the domain is not yet deleted.

src/tests/Feature/Documents/ReceiptTest.php
22

You can just Payment::whereIn('id', $paymentIDs)->delete(). Also, you should do the same in teardown. I guess this might be why the stripe test failed.

This revision now requires changes to proceed.Oct 7 2020, 2:57 PM
  • Verify a user's domain is ldapready before attempting to create the user. Return the job to the queue with a 60 second delay if the domain is not ready
vanmeeuwen marked 4 inline comments as done.
  • Improve based on feedback
This revision is now accepted and ready to land.Oct 7 2020, 3:12 PM
This revision was automatically updated to reflect the committed changes.