Page MenuHomePhorge
Differential D1600

Fix Utils::serviceUrl()
ClosedPublic
Actions

Authored by machniak on Sep 21 2020, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 2:45 AM
Unknown Object (File)
Mar 17 2024, 12:22 AM
Unknown Object (File)
Feb 10 2024, 1:50 PM
Unknown Object (File)
Jan 29 2024, 7:31 PM
Unknown Object (File)
Jan 19 2024, 8:19 PM
Unknown Object (File)
Jan 9 2024, 11:19 AM
Unknown Object (File)
Dec 21 2023, 11:35 AM
Unknown Object (File)
Dec 21 2023, 1:01 AM
View All 15 Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK1ff0bb044a1e: Fix Utils::serviceUrl()
Summary

I wasn't able to reproduce the \url() issue, so it is
a naive fix. We just don't use \url().

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/url-fix
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30847
Build 11467: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Sep 21 2020, 3:39 PM
machniak created this revision.
Harbormaster completed remote builds in B30847: Diff 4243.Sep 21 2020, 3:39 PM
vanmeeuwen accepted this revision.Sep 22 2020, 10:43 AM
This revision is now accepted and ready to land.Sep 22 2020, 10:43 AM
Closed by commit rK1ff0bb044a1e: Fix Utils::serviceUrl() (authored by machniak, committed by vanmeeuwen). · Explain WhySep 22 2020, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Providers/
Payment/
8 lines
15 lines
tests/
Unit/
39 lines

Diff 4243

View Options

src/app/Providers/Payment/Stripe.php

Loading...
View Options

src/app/Utils.php

Loading...
View Options

src/tests/Unit/UtilsTest.php

Loading...