Fixes objectclass member comparison in cmd-sync #5423
Details
Details
Diff Detail
Diff Detail
- Repository
- rP pykolab
- Branch
- dev/5423
- Lint
Lint Errors Severity Location Code Message Error pykolab/utils.py:74 E502 PEP8 E502 Error pykolab/utils.py:75 E128 PEP8 E128 Error pykolab/utils.py:120 E231 PEP8 E231 Error pykolab/utils.py:120 E231 PEP8 E231 Error pykolab/utils.py:127 E712 PEP8 E712 Error pykolab/utils.py:128 E231 PEP8 E231 Error pykolab/utils.py:128 E231 PEP8 E231 Error pykolab/utils.py:141 E713 PEP8 E713 Error pykolab/utils.py:177 E713 PEP8 E713 Error pykolab/utils.py:283 E303 PEP8 E303 Error pykolab/utils.py:403 E251 PEP8 E251 Error pykolab/utils.py:502 E231 PEP8 E231 Error pykolab/utils.py:522 E231 PEP8 E231 Error pykolab/utils.py:528 E231 PEP8 E231 Error pykolab/utils.py:596 E231 PEP8 E231 - Unit
No Test Coverage - Build Status
Buildable 3664 Build 3639: arc lint + arc unit
Event Timeline
Comment Actions
We already added this code snipet to our test system and run a huge "sync --resync" which seams to add users which where not added earlier.
So I'd like to say we tested it intensively and feel real good with this patch. It's working as intended.
| pykolab/utils.py | ||
|---|---|---|
| 391 | This isn't generally our coding style -- difficult to read. This can just be: if not result.has_key('objectclass'):
result['objectclass'] = []
if result['objectclass'] is None:
result['objectclass'] = []
if not isinstance(result['objectclass'], list):
result['objectclass'] = [result['objectclass']]
result['objectclass'] = [x.lower() for x in result['objectclass']] | |