Normalize objectclass attribute values (#5423)
ClosedPublic
Actions

Authored by machniak on May 11 2016, 3:00 PM.

Details

Reviewers

Group Reviewers

Commits

rP4702e7b78fde: Normalize objectclass attribute values (#5423)
rPe7bbf6640766: Normalize objectclass attribute values (#5423)

Summary

Fixes objectclass member comparison in cmd-sync #5423

Diff Detail

Repository

rP pykolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 343.May 11 2016, 3:00 PM

machniak retitled this revision from to Normalize objectclass attribute values (#5423).

machniak updated this object.

machniak edited the test plan for this revision. (Show Details)

machniak added a reviewer: PyKolab Developers.

We already added this code snipet to our test system and run a huge "sync --resync" which seams to add users which where not added earlier.
So I'd like to say we tested it intensively and feel real good with this patch. It's working as intended.

vanmeeuwen requested changes to this revision.May 13 2016, 10:56 AM

vanmeeuwen added a reviewer: vanmeeuwen.

vanmeeuwen subscribed.

vanmeeuwen added inline comments.

pykolab/utils.py

398

This isn't generally our coding style -- difficult to read.

This can just be:

if not result.has_key('objectclass'):
  result['objectclass'] = []

if result['objectclass'] is None:
  result['objectclass'] = []

if not isinstance(result['objectclass'], list):
  result['objectclass'] = [result['objectclass']]

result['objectclass'] = [x.lower() for x in result['objectclass']]

This revision now requires changes to proceed.May 13 2016, 10:56 AM