Fixes objectclass member comparison in cmd-sync #5423
Details
Details
Diff Detail
Diff Detail
- Repository
- rP pykolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
We already added this code snipet to our test system and run a huge "sync --resync" which seams to add users which where not added earlier.
So I'd like to say we tested it intensively and feel real good with this patch. It's working as intended.
| pykolab/utils.py | ||
|---|---|---|
| 398 | This isn't generally our coding style -- difficult to read. This can just be: if not result.has_key('objectclass'):
result['objectclass'] = []
if result['objectclass'] is None:
result['objectclass'] = []
if not isinstance(result['objectclass'], list):
result['objectclass'] = [result['objectclass']]
result['objectclass'] = [x.lower() for x in result['objectclass']] | |