Page MenuHomePhorge
Differential D1546

Fix UserAliasObserver
ClosedPublic
Actions

Authored by vanmeeuwen on Sep 14 2020, 2:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 1:49 PM
Unknown Object (File)
Sat, Apr 20, 7:55 AM
Unknown Object (File)
Sat, Apr 20, 7:03 AM
Unknown Object (File)
Fri, Apr 19, 7:21 PM
Unknown Object (File)
Fri, Apr 19, 3:48 AM
Unknown Object (File)
Thu, Apr 18, 7:36 AM
Unknown Object (File)
Sat, Apr 13, 12:53 PM
Unknown Object (File)
Sat, Apr 13, 10:21 AM
View All 53 Files
Subscribers
Restricted Project

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK87a798d63679: Fix UserAliasObserver
Summary

Aligned with the recent alias validation changes

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak requested review of this revision.Sep 14 2020, 2:55 PM
machniak created this revision.
Harbormaster completed remote builds in B30577: Diff 4051.Sep 14 2020, 2:55 PM
machniak updated this revision to Diff 4057.Sep 14 2020, 3:15 PM
  • Add test adding an alias to deleted user's email
Harbormaster completed remote builds in B30580: Diff 4057.Sep 14 2020, 3:15 PM
machniak updated this revision to Diff 4063.Sep 14 2020, 3:21 PM
  • Remove redundant checks from the observer
Harbormaster completed remote builds in B30583: Diff 4063.Sep 14 2020, 3:21 PM
machniak updated this revision to Diff 4069.Sep 14 2020, 3:41 PM
  • Add domain:set-status command
Harbormaster completed remote builds in B30589: Diff 4069.Sep 14 2020, 3:41 PM
machniak updated this revision to Diff 4075.Sep 14 2020, 3:50 PM
  • Add domain:add command
Harbormaster completed remote builds in B30592: Diff 4075.Sep 14 2020, 3:50 PM
machniak updated this revision to Diff 4081.Sep 14 2020, 4:15 PM
  • Add domain:set-wallet command
Harbormaster completed remote builds in B30598: Diff 4081.Sep 14 2020, 4:15 PM
vanmeeuwen commandeered this revision.Sep 14 2020, 4:17 PM
vanmeeuwen added a reviewer: machniak.
vanmeeuwen updated this revision to Diff 4087.Sep 14 2020, 4:39 PM
  • Make domain:add treat existing yet deleted domains to the best it can
  • Use $wallet->getDiscountRate() for the sku -> entitlement costs
Harbormaster completed remote builds in B30604: Diff 4087.Sep 14 2020, 4:39 PM
vanmeeuwen updated this revision to Diff 4093.Sep 14 2020, 4:45 PM
  • Just the sku cost
Harbormaster completed remote builds in B30607: Diff 4093.Sep 14 2020, 4:45 PM
vanmeeuwen updated this revision to Diff 4096.Sep 14 2020, 4:51 PM
  • Updates
Harbormaster completed remote builds in B30610: Diff 4096.Sep 14 2020, 4:51 PM
vanmeeuwen updated this revision to Diff 4099.Sep 14 2020, 4:54 PM
  • ->first()
Harbormaster completed remote builds in B30613: Diff 4099.Sep 14 2020, 4:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2020, 5:02 PM
Closed by commit rK87a798d63679: Fix UserAliasObserver (authored by vanmeeuwen). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
75 lines
DomainSetStatus.php
DomainStatus.php
22 lines
68 lines
2 lines
Observers/
19 lines
tests/
Feature/
Controller/
8 lines

Diff 4105

View Options

src/app/Console/Commands/DomainAdd.php

Loading...
View Options

src/app/Console/Commands/DomainSetStatus.php

Loading...
View Options

src/app/Console/Commands/DomainSetWallet.php

Loading...
View Options

src/app/Console/Commands/DomainStatus.php

Loading...
View Options

src/app/Observers/UserAliasObserver.php

Loading...
View Options

src/tests/Feature/Controller/UsersTest.php

Loading...