Fixes #5401
Details
Details
- Reviewers
vanmeeuwen - Group Reviewers
PyKolab Developers - Commits
- rP899fd8ec78ae: Add RDATE support (#5401)
rP08d096f873f8: Add RDATE support (#5401)
Diff Detail
Diff Detail
- Repository
- rP pykolab
- Branch
- dev/5401
- Lint
Lint Errors - Unit
No Test Coverage - Build Status
Buildable 3571 Build 3546: arc lint + arc unit
Event Timeline
Comment Actions
Please see the inline commentary.
| pykolab/xml/event.py | ||
|---|---|---|
| 989 | Does the existence of an _rdate.params attribute imply that the 'TZID' key is set? | |
| 1367 | Should not both clauses in this || statement evaluate to True? It seems that for a recurring event, .isValid() should be true as well as (implicitly) a positive number of occurrences should exist. Note also that a "recurring" event with only one occurrence would validate len() > 0, which may not yield the expected results. Also note that self.event (the lower-level XML level) and self.get_recurrence_dates() work on two different in-memory representations of the event, allowing for race-conditions. Perhaps it is best to ensure the complete event is read and parsed, which should logically lead to two equals copies. | |
Comment Actions
This doesn't really have a "pending approval" or "require answers to questions" or somesuch state, so I'm going to have to make this re-appear on your radar by requesting changes.
| pykolab/xml/event.py | ||
|---|---|---|
| 989 | Yes, it does. According to icalendar code, but I'll add additional check. | |
| 1367 | RDATE specified additional occurrences. So if there's one RDATE it is recurring event. There can be an event with RDATE but no recurrence rule. So, I think this is correct. I don't get the last paragraph. get_recurrence_dates() also uses self.event. | |