Page MenuHomekolab.org

Trim spaces in surname/givenname/sn when generating mail/alias (#5360)
ClosedPublic

Authored by machniak on Apr 18 2016, 5:35 PM.

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak updated this revision to Diff 286.Apr 18 2016, 5:35 PM
machniak retitled this revision from to Trim spaces in surname/givenname/sn when generating mail/alias (#5360).
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen requested changes to this revision.May 4 2016, 3:56 PM
vanmeeuwen added a reviewer: vanmeeuwen.
vanmeeuwen added a subscriber: vanmeeuwen.

This may be better suited for utils.normalize(), which already iterates over keys and values.

This revision now requires changes to proceed.May 4 2016, 3:56 PM
machniak updated this revision to Diff 331.May 5 2016, 1:38 PM
machniak edited edge metadata.

Moved the trimming code to utils.normalize(), added tests

machniak updated this revision to Diff 332.May 5 2016, 1:40 PM
machniak edited edge metadata.

Removed redundant import

vanmeeuwen accepted this revision.May 13 2016, 10:45 AM
vanmeeuwen edited edge metadata.
This revision is now accepted and ready to land.May 13 2016, 10:45 AM
This revision was automatically updated to reflect the committed changes.