Page MenuHomekolab.org

Catch exceptions from modules to prevent from killing the wallace process (#5370)
ClosedPublic

Authored by machniak on Apr 5 2016, 5:08 PM.

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak updated this revision to Diff 258.Apr 5 2016, 5:08 PM
machniak retitled this revision from to Catch exceptions from modules to prevent from killing the wallace process (#5370).
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen requested changes to this revision.Apr 13 2016, 4:44 PM
vanmeeuwen added a reviewer: vanmeeuwen.
vanmeeuwen added a subscriber: vanmeeuwen.
vanmeeuwen added inline comments.
wallace/modules.py
121

Please remember to import traceback

This revision now requires changes to proceed.Apr 13 2016, 4:44 PM
machniak marked an inline comment as done.Apr 13 2016, 4:56 PM
machniak added inline comments.
wallace/modules.py
121

It is already imported.

machniak requested a review of this revision.Apr 14 2016, 10:27 AM
machniak edited edge metadata.
machniak marked an inline comment as done.
vanmeeuwen accepted this revision.Apr 14 2016, 11:20 AM
vanmeeuwen edited edge metadata.
vanmeeuwen added inline comments.
wallace/modules.py
121

Agreed, sorry.

This revision is now accepted and ready to land.Apr 14 2016, 11:20 AM
This revision was automatically updated to reflect the committed changes.