Page MenuHomePhorge
Differential D125

Catch exceptions from modules to prevent from killing the wallace process (#5370)
ClosedPublic
Actions

Authored by machniak on Apr 5 2016, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 1:21 AM
Unknown Object (File)
Mar 6 2024, 3:05 AM
Unknown Object (File)
Feb 15 2024, 7:06 AM
Unknown Object (File)
Feb 14 2024, 2:06 AM
Unknown Object (File)
Feb 4 2024, 7:24 AM
Unknown Object (File)
Jan 27 2024, 5:54 PM
Unknown Object (File)
Dec 30 2023, 8:53 PM
Unknown Object (File)
Dec 20 2023, 5:31 PM
View All 79 Files
Subscribers
vanmeeuwen

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rP424382ed45b4: Catch exceptions from modules to prevent from killing the wallace process…
rP7463f1e43d19: Catch exceptions from modules to prevent from killing the wallace process…
Summary

Fixes issue where IMAP connection problems would kill wallace (#5370)

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 258.Apr 5 2016, 5:08 PM
machniak retitled this revision from to Catch exceptions from modules to prevent from killing the wallace process (#5370).
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
vanmeeuwen requested changes to this revision.Apr 13 2016, 4:44 PM
vanmeeuwen added a reviewer: vanmeeuwen.
vanmeeuwen subscribed.
vanmeeuwen added inline comments.
wallace/modules.py
121

Please remember to import traceback

This revision now requires changes to proceed.Apr 13 2016, 4:44 PM
machniak marked an inline comment as done.Apr 13 2016, 4:56 PM
machniak added inline comments.
wallace/modules.py
121

It is already imported.

machniak requested a review of this revision.Apr 14 2016, 10:27 AM
machniak edited edge metadata.
machniak marked an inline comment as done.
vanmeeuwen accepted this revision.Apr 14 2016, 11:20 AM
vanmeeuwen edited edge metadata.
vanmeeuwen added inline comments.
wallace/modules.py
121

Agreed, sorry.

This revision is now accepted and ready to land.Apr 14 2016, 11:20 AM
Closed by commit rP7463f1e43d19: Catch exceptions from modules to prevent from killing the wallace process… (authored by machniak, committed by vanmeeuwen). · Explain WhyApr 14 2016, 11:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
wallace/
6 lines

Diff 269

View Options

wallace/modules.py

Loading...