Differential D1081

Instead of converting the values from zlib:deflate to binary by hand we can use the iolist_to_binary() function from erlang; this allows us to convert also nested iolists.
ClosedPublic
Actions

Authored by mollekopf on Mar 27 2020, 11:39 AM.

Details

Reviewers

machniak

Maniphest Tasks

T5791: Guam crash: "in state passthrough terminated with reason: bad argument in call to erlang:bit_size( ..."

Commits

rEI516ed474dc97: Instead of converting the values from zlib:deflate to binary by hand we can use…

Summary

Patch by hede

Diff Detail

Repository

rEI eimap

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 28789
Build 10390: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 27 2020, 11:39 AM

mollekopf created this revision.

Harbormaster completed remote builds in B28789: Diff 2779.Mar 27 2020, 11:39 AM

Looks like a nice simple change.

This revision is now accepted and ready to land.Mar 28 2020, 8:15 AM

Apply patch to the develop branch

Harbormaster completed remote builds in B28813: Diff 2806.Mar 28 2020, 8:20 AM

mollekopf added a task: T5791: Guam crash: "in state passthrough terminated with reason: bad argument in call to erlang:bit_size( ...".Mar 28 2020, 8:21 AM

Closed by commit rEI516ed474dc97: Instead of converting the values from zlib:deflate to binary by hand we can use… (authored by mollekopf). · Explain WhyMar 28 2020, 10:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

eimap.erl

7 lines

Diff 2779

View Options

Instead of converting the values from zlib:deflate to binary by hand we can use the iolist_to_binary() function from erlang; this allows us to convert also nested iolists.ClosedPublicActions