Page MenuHomekolab.org

Use property_exists instead of array_key_exists on object
AbandonedPublic

Authored by mollekopf on Mar 9 2020, 11:45 AM.

Details

Reviewers
machniak
Group Reviewers
Syncroton Developers
Summary

To avoid a php deprecated warning.

Diff Detail

Repository
rS syncroton
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28456
Build 10201: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 9 2020, 11:45 AM
mollekopf created this revision.

Looks like the mentioned bug has been fixed in PHP 5.2.2, so I'm guessing we can remove the whole method. Oh, actually upstream did it here https://github.com/tine20/syncroton/commit/e847e680ba19d65aa5305d73313a5ea7af2387a7. So, I'm going to update Syncroton version we're using.

machniak abandoned this revision.Mar 9 2020, 12:17 PM

Done in bdfb95825b525 [syncroton master].