Page MenuHomePhorge
Differential D1006

Use property_exists instead of array_key_exists on object
AbandonedPublic
Actions

Authored by mollekopf on Mar 9 2020, 11:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 8:53 PM
Unknown Object (File)
Thu, Mar 28, 4:00 PM
Unknown Object (File)
Mar 1 2024, 2:47 AM
Unknown Object (File)
Feb 16 2024, 12:07 PM
Unknown Object (File)
Feb 15 2024, 9:12 AM
Unknown Object (File)
Jan 18 2024, 9:31 AM
Unknown Object (File)
Dec 31 2023, 2:31 AM
Unknown Object (File)
Dec 31 2023, 12:40 AM
View All 20 Files
Subscribers
None

Details

Reviewers
machniak
Group Reviewers
Syncroton Developers
Summary

To avoid a php deprecated warning.

Diff Detail

Repository
rS syncroton
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28456
Build 10201: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 9 2020, 11:45 AM
mollekopf created this revision.
Harbormaster completed remote builds in B28456: Diff 2518.Mar 9 2020, 11:45 AM
mollekopf added reviewers: machniak, Syncroton Developers.Mar 9 2020, 11:46 AM

Discovered here:
https://bifrost.kolabsystems.com/T333473

machniak added a comment.Mar 9 2020, 12:08 PM

Looks like the mentioned bug has been fixed in PHP 5.2.2, so I'm guessing we can remove the whole method. Oh, actually upstream did it here https://github.com/tine20/syncroton/commit/e847e680ba19d65aa5305d73313a5ea7af2387a7. So, I'm going to update Syncroton version we're using.

machniak abandoned this revision.Mar 9 2020, 12:17 PM

Done in bdfb95825b525 [syncroton master].

Revision Contents
Changeset List

PathSize
lib/
ext/
Syncroton/
2 lines

Diff 2518

View Options

lib/ext/Syncroton/Registry.php

Loading...