HomePhorge

maint: use FileUtil to remove files, not exec
f9a2ffd53054Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

maint: use FileUtil to remove files, not exec

We used to shell out to chmod and rm to clean up temporary files; this lead to
the cleanup method here being one of the largest consumers of walltime.
Replacing that with FileUtil calls is as, or more, secure, and performs
sufficiently well that we can just delegate.

Reviewed-By: Matt Robinson <matt@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU78cb48cea0b1: maint: disable garbage collector during individual test cases.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPUf9a2ffd53054: maint: use FileUtil to remove files, not exec (authored by Daniel Pittman <daniel@puppetlabs.com>).Apr 9 2011, 12:17 AM