HomePhorge

Save and restore indirector configuration around all tests.
f89874994619Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Save and restore indirector configuration around all tests.

One of the most persistent and troublesome parts of the Puppet codebase, in
terms of testing, is the indirector. It has significant global state in the
terminus and cache configuration, and that state was not being preserved
between tests.

Given that the runtime performance cost of doing this, other than the very
ugly code it engenders, is approximately zero (less than 0.5 percent runtime),
and it substantially improves correctness of testing...

Now we save and restore that state around every test.

Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUe3073ac15389: (#9051) More storeconfigs test cleanup.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPUf89874994619: Save and restore indirector configuration around all tests. (authored by Daniel Pittman <daniel@puppetlabs.com>).Aug 31 2011, 4:28 AM