HomePhorge

(#12464) Avoid unnecessarily reloading facts when node_name_fact is not set
f11ee449cbebUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#12464) Avoid unnecessarily reloading facts when node_name_fact is not set

In fixing #8341 we reduced the caching of facts, leading to a performance
regression in puppet apply. Puppet apply loaded facts twice, first to look up
the fact for node_name_fact, and then a second time under the new node name
given by node_name_fact. This optimizes the common case where node_name_fact
is not set so that facts are only looked up once.

Reported in #12310.

Details

Provenance
Patrick Carlisle <patrick@puppetlabs.com>Authored on
Matthaus Litteken <matthaus@puppetlabs.com>Committed on Feb 20 2012, 8:31 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU9312a3188635: Updated CHANGELOG for 2.7.10
Branches
Unknown
Tags
Unknown

Event Timeline

Matthaus Litteken <matthaus@puppetlabs.com> committed rPUf11ee449cbeb: (#12464) Avoid unnecessarily reloading facts when node_name_fact is not set (authored by Patrick Carlisle <patrick@puppetlabs.com>).Feb 20 2012, 8:31 PM