HomePhorge

Accept paths with `~` for `generate` on Windows.
ef2722110586Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Accept paths with ~ for generate on Windows.

The generate function has a fairly strict definition of what is and isn't
legal as a command name, in an effort to keep it reasonably sanitary.

On Windows this included ., -, and any alpha-numeric characters, but not
the ~ character. This blew up when faced with an "8.3" generated path -
something that we legitimately should accept since it can reduce problems
around spaces in path names.

This changes generate to accept that, and adds a specific test to verify that
it continues to work as expected.

Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU4bc6deb5dac5: Make a path absolute on Windows as well as Unix.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPUef2722110586: Accept paths with `~` for `generate` on Windows. (authored by Daniel Pittman <daniel@puppetlabs.com>).Apr 19 2012, 12:08 AM