HomePhorge

(#5274) New comment property for the hosttype
ee7d2f92f9d3Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#5274) New comment property for the hosttype

When the parsefile provider for host parses /etc/hosts, it throws any
inlinecomment away. As a result they are also purged in /etc/hosts after
a puppetrun that detects a change. That could be dangerous because you
will lose information even about unmanaged resources.

So if you have something like

192.168.0.1 hostentry_not_managed_by_puppet # Important comment

in /etc/hosts the endresult will be

192.168.0.1\thostentry_not_managed_by_puppet

This patch introduces a new property "comment" for the host type. The
provider is nearly a complete rewrite and a lot shorter and hopefully
easier to understand.

Details

Provenance
Stefan Schulte <stefan.schulte@taunusstein.net>Authored on
Nick Lewis <nick@puppetlabs.com>Committed on Nov 18 2010, 12:55 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU8efdc769db2e: (#5274) Tests for hostprovider removes comments
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Lewis <nick@puppetlabs.com> committed rPUee7d2f92f9d3: (#5274) New comment property for the hosttype (authored by Stefan Schulte <stefan.schulte@taunusstein.net>).Nov 18 2010, 12:55 AM