HomePhorge

(PUP-3912) Make some methods public where specs were relying on them
eb1843a78e55Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-3912) Make some methods public where specs were relying on them

Previously these methods were made private, but spec tests were still
using them as if they were public. Apparently, rspec 2 didn't enforce
access methods but rspec 3 does, so for the time being simply mark
the methods public (with a note to the user that they shouldn't be
treated as part of a public API).

As a possible future improvement the code could be rewritten to not
test using private methods, but that looks like a fair bit of surgery
for not that much gain at this time. Something to consider as/when
this code is refactored going forward.

Details

Provenance
Kylo Ginsberg <kylo@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU8b3efe596569: (PUP-3912) Add supports_block_expectation shortcut to matchers that do
Branches
Unknown
Tags
Unknown

Event Timeline

Kylo Ginsberg <kylo@puppetlabs.com> committed rPUeb1843a78e55: (PUP-3912) Make some methods public where specs were relying on them (authored by Kylo Ginsberg <kylo@puppetlabs.com>).Jan 26 2015, 8:52 PM