(Maint) Eliminate Windows network lookups
ea9097ae40b1Unpublished
Actions

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

(Maint) Eliminate Windows network lookups

When using a UNC style file path, the windows file provider invokes
File.expand_path('//server/...'), which results in a failed Windows
network lookup. Executing these two tests was previously taking 15.4
seconds.

This commit instead provides a localhost server to short-circuit the
lookup. The tests now only take 1.7 seconds.

Details

Provenance

Josh Cooper <josh@puppetlabs.com>	Authored on
vanmeeuwen	Pushed on Jun 2 2015, 2:22 PM

Parents

rPUc30f82b0ee62: Merge branch 'maint/master/fixup-source-tests'

Branches

Unknown

Tags

Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPUea9097ae40b1: (Maint) Eliminate Windows network lookups (authored by Josh Cooper <josh@puppetlabs.com>).Nov 26 2013, 6:32 PM

Changes (2)

Path

Size

spec/

unit/

settings/

path_setting_spec.rb

type/

file_spec.rb

rPUea9097ae40b1

View Options

spec/unit/settings/path_setting_spec.rb