HomePhorge

(#12464) Avoid unnecessarily reloading facts when node_name_fact is not set
e32a39cde2eaUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#12464) Avoid unnecessarily reloading facts when node_name_fact is not set

In fixing #8341 we reduced the caching of facts, leading to a performance
regression in puppet apply. Puppet apply loaded facts twice, first to look up
the fact for node_name_fact, and then a second time under the new node name
given by node_name_fact. This optimizes the common case where node_name_fact
is not set so that facts are only looked up once.

Reported in #12310.

Details

Provenance
Patrick Carlisle <patrick@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUec3bba570537: Merge pull request #433 from pcarlisle/ticket/2.7.x/12268-upstart
Branches
Unknown
Tags
Unknown

Event Timeline

Patrick Carlisle <patrick@puppetlabs.com> committed rPUe32a39cde2ea: (#12464) Avoid unnecessarily reloading facts when node_name_fact is not set (authored by Patrick Carlisle <patrick@puppetlabs.com>).Feb 7 2012, 12:03 AM