HomePhorge

(PUP-2756) Fix test of future parser evaluation of empty string
e0e58184eb31Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-2756) Fix test of future parser evaluation of empty string

An empty string is no longer undef when parser is future, and will
evaluate as true in a conditional test. This commit fixes a test that
was failing this check for the future parser. This, and several like
it, was an acceptance test which was just compiling a simple manifest
with some conditional logic to test evaluation of conditionals. Since
acceptance tests are expensive, I've pulled them back into the
integration specs.

The actual test being fixed is
acceptance/tests/apply/conditionals/should_evaluate_empty.rb which is
now the two 'evaluates empty string as <false|true>' specs in the new
spec/integration/parser/conditionals_spec.rb

Details

Provenance
Josh Partlow <joshua.partlow@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU77845e9871be: (maint) Refactor shared example from parser/compiler_spec
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Partlow <joshua.partlow@puppetlabs.com> committed rPUe0e58184eb31: (PUP-2756) Fix test of future parser evaluation of empty string (authored by Josh Partlow <joshua.partlow@puppetlabs.com>).Jun 12 2014, 11:24 PM