HomePhorge

(#6541) Use the same filebucket for backup and restore
d937ae3a506fUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

(#6541) Use the same filebucket for backup and restore

The acceptance test for #6541 was using `puppet filebucket backup -l
/dev/null` to cause a 0-length file to be created in the agent's
filebucket, and then attempting to retrieve the file using:

file { ...:
  content => '{md5}d41d8cd98f00b204e9800998ecf8427e'

However, this was failing because the former was writing to
${vardir}/bucket, while the latter was trying to read from
${vardir}/clientbucket, and failing to find the 0-length file.

This test reported a false positive earlier, because the test was
reusing the clientbucket from a previous test. Now that the acceptance
tests clean the agent vardir, it uncovered this problem.

This commit changes the test to create a 0-length file, then
overwrites it, causing the old file to be backed up into the
clientbucket.

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU765036c707a2: Merge pull request #342 from daniel-pittman/refactor/2.6.x/11996-spec…
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPUd937ae3a506f: (#6541) Use the same filebucket for backup and restore (authored by Josh Cooper <josh@puppetlabs.com>).Jan 23 2012, 11:51 PM