HomePhorge

(PUP-1407) Fix specs on 187
d65211e0c25dUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-1407) Fix specs on 187

In ruby 1.8.7, OpenSSL::X509::Name does not include Comparable, so == is
not based on the <=> operator. As a result, comparing two Name objects
that have the same string representation will return false. In ruby 1.9,
the class includes the Comparable module. Changed the test to just compare
the String representations.

The other test was failing for me on ruby 187, and it seemed completely
unnecessary to compute 2**158 every time the test runs.

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUe7431c8189ff: Merge branch 'pr/2238'
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPUd65211e0c25d: (PUP-1407) Fix specs on 187 (authored by Josh Cooper <josh@puppetlabs.com>).Feb 7 2014, 11:47 PM