HomePhorge

Fix Rails schema setup on Windows.
d565a7fb794cUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix Rails schema setup on Windows.

There were several problems with the StoreConfig Rails schema building code on
Windows, starting with the use of /dev/null to discard migration output.

Unfortunately, this was hard to debug - it broke tests silently because of the
hacking on $stdout, and didn't report anything about failures.

Now, instead of discarding the output we capture it in memory, and report any
exception we encounter along with the complete textual output at the time of
failure.

This improves the ability to debug errors in this code, along with making it
work transparently on any platform.

Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>

Details

Provenance
Daniel Pittman <daniel@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUfc595ff576ed: Make `binwrite` emulation work on Windows.
Branches
Unknown
Tags
Unknown

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPUd565a7fb794c: Fix Rails schema setup on Windows. (authored by Daniel Pittman <daniel@puppetlabs.com>).Apr 19 2012, 12:08 AM