HomePhorge

maint: Fix Face testing bug 1.9.2 revealed.
d522b0b82428Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

maint: Fix Face testing bug 1.9.2 revealed.

Ruby 1.8.7 is fairly lax about various bits of introspection, including that
we can't tell much about what arguments a block takes. Ruby 1.9.2 makes it
possible to do this, though.

Meanwhile, the Faces system uses this to make sure that scripts and actions
take the right set of arguments, to avoid surprises: failing early and
explicitly is better than failing at runtime.

Which, in final turn, exposes that I forgot to accept the right arguments in a
couple of my testing actions for Faces, but didn't notice because 1.8.7
doesn't check that, and I didn't test on 1.9.2.

Details

Event Timeline

Daniel Pittman <daniel@puppetlabs.com> committed rPUd522b0b82428: maint: Fix Face testing bug 1.9.2 revealed. (authored by Daniel Pittman <daniel@puppetlabs.com>).Jul 25 2011, 8:06 PM